Public bug reported:

The mlx-trio module's IRQ handler prints errors and additional debug
info in case of errors. However, these prints can be excessive in
certain cases, thereby interfering with other functions. This patch
limits the message amount.

SRU Justification:

[Impact]
In cases where the mlx-trio module continuously receives interrupts, it prints 
a lot of messages which can potentially affect the console output and clutter 
dmesg logs.

[Fix]
This commit calls dev_err_ratelimited() instead of dev_err() to limit the 
amount of messages.

[Test Case]
When TRIO receives a bunch of PIO completion errors or PCIe link disabled 
errors, a ton of error messages from the IRQ handler can be seen, which has 
been limited by this patch.

[Regression Potential]
Regression potential can be considered minimum since the patch does not change 
any functions of the driver, but merely makes the error log more readable.

** Affects: linux-bluefield (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1926424

Title:
  Use rate-limited prints for mlx-trio errors

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/1926424/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to