Thanks for the patches Sergio. The changes LGTM, the patch was provided
by upstream (more like a workaround for the stable release) and they
said it'd be safe.
A small thing I'd fix in the changelog of both packages is to align the
text better. Instead of:
* Fix FTBFS with OpenLDAP 2.5. (LP: #1929859)
- d/p/fixes/fix-ftbfs-openldap-2.5.patch: New patch to rename
wldap32's 'ldap_connect' to something else so that it doesn't conflict
with OpenLDAP's function with the same name.
I'd use:
* Fix FTBFS with OpenLDAP 2.5. (LP: #1929859)
- d/p/fixes/fix-ftbfs-openldap-2.5.patch: New patch to rename
wldap32's 'ldap_connect' to something else so that it doesn't conflict
with OpenLDAP's function with the same name.
And the added patch is missing the Description header (in both packages)
which I think it is important.
Apart from that, +1 from me for both packages.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1929859
Title:
wine and wine-development FTBFS with OpenLDAP 2.5
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wine/+bug/1929859/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
