Thanks for the patch and for working on this bug, Athos.

A few comments:

- Since this is an SRU, the version will be a bit different than in a
normal upload to a development version.  In this particular case, the
version should be:

  0.5.0-2ubuntu0.1

- The "Origin:" DEP-3 header should contain the direct link to the
commit.  It should also specify if this patch is a backport or if it was
applied cleanly from upstream.  For example:

  Origin: upstream, https://link.to.commit

or

  Origin: backport, https://link.to.commit

Other than that, the patch LGTM.

The SRU template also LGTM, but there's a small nit in the Test Case
section: the "docker build" command expects the directory where the
build will happen as an argument, so I think the command should be:

   docker build -t golang-docker-credential-helpers:test .

Other than that, I followed the reproduction steps and verified that (1)
the error is indeed hapening, and (2) it is fixed by this patch.

Let me know when you update the patch and I can upload it.  Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1813003

Title:
  Invalid free while running docker build

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-github-docker-docker-credential-helpers/+bug/1813003/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to