** Description changed:

  [Impact]
- The expected to fail 'raw gso min size - 1' test in psock_snd.sh is always 
failing with: 
+ The expected to fail 'raw gso min size - 1' test in psock_snd.sh is always 
failing with:
  
-   raw gso min size - 1 (expected to fail)
-   tx: 1524
-   rx: 1472
-   OK
+   raw gso min size - 1 (expected to fail)
+   tx: 1524
+   rx: 1472
+   OK
  
  This is because after commit 7c6d2ec ("net: be more gentle about silly
  gso requests coming from user"), we relaxed the min gso_size check in 
virtio_net_hdr_to_skb().
  So when a packet which is smaller then the gso_size,
  GSO for this packet will not be set, the packet will be
  send/recv successfully.
  
  [Fix]
- * cfba3fb68960b4 selftests/net: remove min gso test in packet_snd 
+ * cfba3fb68960b4 selftests/net: remove min gso test in packet_snd
  
- This patch can be
+ This patch can be cherry-picked into affected kernels.
  
  [Test]
- Run this psock_snd.sh script, 
- 
+ Run this psock_snd.sh script,
  
  [Impact]
- 
  
  [Original Bug Report]
  Testing failed on focal/linux 5.4.0-44.48:
      amd64: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/l/linux/20200812_171444_31971@/log.gz
      arm64: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/l/linux/20200812_210509_145fd@/log.gz
      ppc64el: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/l/linux/20200812_165855_1dabd@/log.gz
      s390x: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/l/linux/20200812_153600_9c7cb@/log.gz
  
  psock_snd.sh output:
  
  16:28:30 DEBUG| [stdout] # selftests: net: psock_snd.sh
  16:28:31 DEBUG| [stdout] # dgram
  16:28:31 DEBUG| [stdout] # tx: 128
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # dgram bind
  16:28:31 DEBUG| [stdout] # tx: 128
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw
  16:28:31 DEBUG| [stdout] # tx: 142
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw bind
  16:28:31 DEBUG| [stdout] # tx: 142
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw qdisc bypass
  16:28:31 DEBUG| [stdout] # tx: 142
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw vlan
  16:28:31 DEBUG| [stdout] # tx: 146
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw vnet hdr
  16:28:31 DEBUG| [stdout] # tx: 152
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw csum_off
  16:28:31 DEBUG| [stdout] # tx: 152
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw csum_off with bad offset (fails)
  16:28:31 DEBUG| [stdout] # ./psock_snd: write: Invalid argument
  16:28:31 DEBUG| [stdout] # raw min size
  16:28:31 DEBUG| [stdout] # tx: 42
  16:28:31 DEBUG| [stdout] # rx: 0
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw mtu size
  16:28:31 DEBUG| [stdout] # tx: 1514
  16:28:31 DEBUG| [stdout] # rx: 1472
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw mtu size + 1 (fails)
  16:28:31 DEBUG| [stdout] # ./psock_snd: write: Message too long
  16:28:31 DEBUG| [stdout] # raw vlan mtu size + 1 (fails)
  16:28:31 DEBUG| [stdout] # ./psock_snd: write: Message too long
  16:28:32 DEBUG| [stdout] # dgram mtu size
  16:28:32 DEBUG| [stdout] # tx: 1500
  16:28:32 DEBUG| [stdout] # rx: 1472
  16:28:32 DEBUG| [stdout] # OK
  16:28:32 DEBUG| [stdout] #
  16:28:32 DEBUG| [stdout] # dgram mtu size + 1 (fails)
  16:28:32 DEBUG| [stdout] # ./psock_snd: write: Message too long
  16:28:32 DEBUG| [stdout] # raw truncate hlen (fails: does not arrive)
  16:28:32 DEBUG| [stdout] # tx: 14
  16:28:32 DEBUG| [stdout] # ./psock_snd: recv: Resource temporarily unavailable
  16:28:32 DEBUG| [stdout] # raw truncate hlen - 1 (fails: EINVAL)
  16:28:32 DEBUG| [stdout] # ./psock_snd: write: Invalid argument
  16:28:32 DEBUG| [stdout] # raw gso min size
  16:28:32 DEBUG| [stdout] # tx: 1525
  16:28:32 DEBUG| [stdout] # rx: 1473
  16:28:32 DEBUG| [stdout] # OK
  16:28:32 DEBUG| [stdout] #
  16:28:32 DEBUG| [stdout] # raw gso min size - 1 (fails)
  16:28:32 DEBUG| [stdout] # tx: 1524
  16:28:32 DEBUG| [stdout] # rx: 1472
  16:28:32 DEBUG| [stdout] # OK
  16:28:32 DEBUG| [stdout] #
  16:28:32 DEBUG| [stdout] not ok 22 selftests: net: psock_snd.sh # exit=1
  
  This failure is similar to bug 1884234, however, this test didn't fail
  on ADT with focal/linux before 5.4.0-44.48.

** Description changed:

  [Impact]
  The expected to fail 'raw gso min size - 1' test in psock_snd.sh is always 
failing with:
  
    raw gso min size - 1 (expected to fail)
    tx: 1524
    rx: 1472
    OK
  
  This is because after commit 7c6d2ec ("net: be more gentle about silly
  gso requests coming from user"), we relaxed the min gso_size check in 
virtio_net_hdr_to_skb().
  So when a packet which is smaller then the gso_size,
  GSO for this packet will not be set, the packet will be
  send/recv successfully.
  
  [Fix]
  * cfba3fb68960b4 selftests/net: remove min gso test in packet_snd
  
  This patch can be cherry-picked into affected kernels.
  
  [Test]
- Run this psock_snd.sh script,
+ Run this psock_snd.sh script, this test will no longer exist and the script 
can proceed to the next test.
  
  [Impact]
  
  [Original Bug Report]
  Testing failed on focal/linux 5.4.0-44.48:
      amd64: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/l/linux/20200812_171444_31971@/log.gz
      arm64: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/l/linux/20200812_210509_145fd@/log.gz
      ppc64el: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/l/linux/20200812_165855_1dabd@/log.gz
      s390x: 
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/l/linux/20200812_153600_9c7cb@/log.gz
  
  psock_snd.sh output:
  
  16:28:30 DEBUG| [stdout] # selftests: net: psock_snd.sh
  16:28:31 DEBUG| [stdout] # dgram
  16:28:31 DEBUG| [stdout] # tx: 128
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # dgram bind
  16:28:31 DEBUG| [stdout] # tx: 128
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw
  16:28:31 DEBUG| [stdout] # tx: 142
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw bind
  16:28:31 DEBUG| [stdout] # tx: 142
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw qdisc bypass
  16:28:31 DEBUG| [stdout] # tx: 142
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw vlan
  16:28:31 DEBUG| [stdout] # tx: 146
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw vnet hdr
  16:28:31 DEBUG| [stdout] # tx: 152
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw csum_off
  16:28:31 DEBUG| [stdout] # tx: 152
  16:28:31 DEBUG| [stdout] # rx: 142
  16:28:31 DEBUG| [stdout] # rx: 100
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw csum_off with bad offset (fails)
  16:28:31 DEBUG| [stdout] # ./psock_snd: write: Invalid argument
  16:28:31 DEBUG| [stdout] # raw min size
  16:28:31 DEBUG| [stdout] # tx: 42
  16:28:31 DEBUG| [stdout] # rx: 0
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw mtu size
  16:28:31 DEBUG| [stdout] # tx: 1514
  16:28:31 DEBUG| [stdout] # rx: 1472
  16:28:31 DEBUG| [stdout] # OK
  16:28:31 DEBUG| [stdout] #
  16:28:31 DEBUG| [stdout] # raw mtu size + 1 (fails)
  16:28:31 DEBUG| [stdout] # ./psock_snd: write: Message too long
  16:28:31 DEBUG| [stdout] # raw vlan mtu size + 1 (fails)
  16:28:31 DEBUG| [stdout] # ./psock_snd: write: Message too long
  16:28:32 DEBUG| [stdout] # dgram mtu size
  16:28:32 DEBUG| [stdout] # tx: 1500
  16:28:32 DEBUG| [stdout] # rx: 1472
  16:28:32 DEBUG| [stdout] # OK
  16:28:32 DEBUG| [stdout] #
  16:28:32 DEBUG| [stdout] # dgram mtu size + 1 (fails)
  16:28:32 DEBUG| [stdout] # ./psock_snd: write: Message too long
  16:28:32 DEBUG| [stdout] # raw truncate hlen (fails: does not arrive)
  16:28:32 DEBUG| [stdout] # tx: 14
  16:28:32 DEBUG| [stdout] # ./psock_snd: recv: Resource temporarily unavailable
  16:28:32 DEBUG| [stdout] # raw truncate hlen - 1 (fails: EINVAL)
  16:28:32 DEBUG| [stdout] # ./psock_snd: write: Invalid argument
  16:28:32 DEBUG| [stdout] # raw gso min size
  16:28:32 DEBUG| [stdout] # tx: 1525
  16:28:32 DEBUG| [stdout] # rx: 1473
  16:28:32 DEBUG| [stdout] # OK
  16:28:32 DEBUG| [stdout] #
  16:28:32 DEBUG| [stdout] # raw gso min size - 1 (fails)
  16:28:32 DEBUG| [stdout] # tx: 1524
  16:28:32 DEBUG| [stdout] # rx: 1472
  16:28:32 DEBUG| [stdout] # OK
  16:28:32 DEBUG| [stdout] #
  16:28:32 DEBUG| [stdout] not ok 22 selftests: net: psock_snd.sh # exit=1
  
  This failure is similar to bug 1884234, however, this test didn't fail
  on ADT with focal/linux before 5.4.0-44.48.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1892213

Title:
  psock_snd.sh in net from ubuntu_kernel_selftests ADT failure with
  focal/groovy/hirsute/impish

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1892213/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to