> Keeping the patches separate is good practice in that they might not all be accepted upstream at the same time.
Ah that makes sense! > The master branch of the gnucash repo seems to only include the debian/ directory, not the upstream files. This threw me off and that's why I made a patch that made a patch, thinking that's what would have had to happen. I see that while that needs to happen sometimes for some projects (libreoffice), it's not a hard rule. > Well, the "Bug 798156 - glib 2.68.0 breaks gnucash" patch never was sufficient on top of version 4.4 of gnucash. I could have sworn I tested it but looking back at my notes from when I first opened the PR, you must be right. I had definitely convinced myself that it fixed the issue but I was wrong. > What you put in your Debian MR seems to be the same as in your PPA. Yep, I was rushing and had incorrectly remembered that the patch had fixed the problem and was hoping it still would fix it. > TBH I fear that there would have been a much simpler solution: > > https://gitlab.gnome.org/GNOME/glib/-/issues/2331#note_1067322 > > But I saw that comment only when the fix was working, and now I'm disinclined > to try it with the risk to find out that the work I did was wasted... Darnit I should have caught this too. @Gunnar, @Brian thanks so much for answering my questions. I'll try to learn from this experience and avoid these same mistakes next time :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1923642 Title: glib can no longer be included in extern "C" blocks To manage notifications about this bug go to: https://bugs.launchpad.net/gnucash/+bug/1923642/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
