Okay, this is what appears to have happened.

During the backport of:

commit 5b1c525b1f3608156884aed0dc5e925306c1e260
Author: Dmytro Linkin <dlin...@nvidia.com>
Date:   Thu Jan 21 14:15:22 2021 +0200
Subject: util: Add phys_port_name support on virPCIGetNetName
Link: 
https://github.com/libvirt/libvirt/commit/5b1c525b1f3608156884aed0dc5e925306c1e260

Another refactor commit seems to have been squashed together and
included:

commit 77401d549c52ba2b11c2132a8ca41d73a4130c85
Author: Laine Stump <la...@redhat.com>
Date:   Mon Oct 26 22:04:31 2020 -0400
Subject: util:  refactor function to simplify and remove label
Link: 
https://github.com/libvirt/libvirt/commit/77401d549c52ba2b11c2132a8ca41d73a4130c85

This refactor commit directly depends on DIR* being changed to g_autoptr
in the below commit:

commit c0ae4919e386cda6e21d3ba022ee187e8b09793b
Author: Laine Stump <la...@redhat.com>
Date:   Sun Oct 25 17:50:51 2020 -0400
Subject: change DIR* int g_autoptr(DIR) where appropriate
Link: 
https://github.com/libvirt/libvirt/commit/c0ae4919e386cda6e21d3ba022ee187e8b09793b#diff-d44ea20881ddbf7bd7b9e4fa9d2a6454812e5109e94160e5f97e2d40ff93a9ca

I think squashing "util:  refactor function to simplify and remove
label" into "util: Add phys_port_name support on virPCIGetNetName" was
probably a bad idea here, without also taking on "change DIR* int
g_autoptr(DIR) where appropriate".

I'll try come up with a slightly more sensible backport, possibly
keeping the initial implementation.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1943481

Title:
  libvirtd crashes when creating network interface pools in
  6.0.0-0ubuntu8.13

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1943481/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to