[sts-sponsors]
* The patch '0002-lp1900617-When-gateway-sends-failure-response-include-
text-in-.patch'[0] introduce a 'import mock', but python-mock nor
python3-mock is part of the build-Depends: in d/control.
Which make me doubt that this part of the code wasn't probably tested ?
Or is it simply an oversight when finalizing the patch for sponsorship ?
[0] -
0002-lp1900617-When-gateway-sends-failure-response-include-text-in-.patch:43:+import
mock
0002-lp1900617-When-gateway-sends-failure-response-include-text-in-.patch:57:+
with mock.patch.object(client, "session") as mock_session:
Ideally, we try to avoid unless very good rational is provided to add
'Build-Depends' for a stable package.
2 Options I can think of, I'll let it to your judgment since you are
more aware of this case than I do:
* Remove the test unit
* Add 'python3-mock' as a Build-Depends:'. If you take that path, make sure to
have good justification that we can provide to the SRU team.
I'm still reviewing, I'll update the bug, If I find anything else.
- Eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1900617
Title:
gateway error detail is not passed along in raised exception
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-etcd3gw/+bug/1900617/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
