FYI - tested and uploaded the libvirt fix along the SRU upload for bug 1927519. This bug will need an SRU template for that as well, adding it now.
** Description changed: + SRU-Template for a libvirt upload to this bug + + [Impact] + + * The SRU of the new dwarves made libvirt an FTBFS + due to changed behavior of pdwtags + + * The change in libvirt will continue to ignore pdwtags + as it did before to match former builds. + + [Test Plan] + + * Has to build successfully again + + * This has no other impact as we really make + it "as it was" before dwarves changed. Nevertheless we will + do a general regression test once in -proposed + + [Where problems could occur] + + * As I said this makes the changes in dwarves a no-op, thereby + no changes are expected. Therefore I can't point to a specific + area and will test generically. + + [Other Info] + + * n/a + + --- + Hi, I faced an regression-in-release breaking libvirt builds in Bionic. I found this to be related to the recent release of https://launchpad.net/ubuntu/+source/dwarves-dfsg/1.21-0ubuntu1~18.04 It is locally reproducible in sbuild if you build it in bionic right now. It will break checking some structs. Example: (bionic-amd64)root@Keschdeichel:/build/libvirt-OfdbiS/libvirt-4.0.0/debian/build/src# make V=1 check-local ... - enum remote_auth_type { + enum remote_auth_type { - REMOTE_AUTH_NONE = 0, - REMOTE_AUTH_SASL = 1, + REMOTE_AUTH_NONE = 0, + REMOTE_AUTH_SASL = 1, - REMOTE_AUTH_POLKIT = 2, - }; - + REMOTE_AUTH_POLKIT = 2, + }; There are much more, but all of them just differ in whitespace. As if some tool was updated now breaking all the tests while the content that matters is actually fine. One element of this comparison lives in the source like src/remote_protocol-structs which has: enum remote_auth_type { - REMOTE_AUTH_NONE = 0, - REMOTE_AUTH_SASL = 1, - REMOTE_AUTH_POLKIT = 2, + REMOTE_AUTH_NONE = 0, + REMOTE_AUTH_SASL = 1, + REMOTE_AUTH_POLKIT = 2, }; But the generated content was changed to be aligned. I found this to use pdwtags from dwarves which is # apt-cache policy dwarves dwarves: - Installed: 1.21-0ubuntu1~18.04 - Candidate: 1.21-0ubuntu1~18.04 - Version table: - *** 1.21-0ubuntu1~18.04 500 - 500 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages - 500 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64 Packages - 100 /var/lib/dpkg/status - 1.10-2.1build1 500 - 500 http://archive.ubuntu.com/ubuntu bionic/universe amd64 Packages + Installed: 1.21-0ubuntu1~18.04 + Candidate: 1.21-0ubuntu1~18.04 + Version table: + *** 1.21-0ubuntu1~18.04 500 + 500 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages + 500 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64 Packages + 100 /var/lib/dpkg/status + 1.10-2.1build1 500 + 500 http://archive.ubuntu.com/ubuntu bionic/universe amd64 Packages Going back to the release version $ apt install dwarves=1.10-2.1build1 => fixes the FTBFS. Formerly the too old pdwtags was detected as broken in libvirt. But the new one is accepted and fails as the output mismatches. Old: (bionic-amd64)root@Keschdeichel:/build/libvirt-OfdbiS/libvirt-4.0.0/debian/build/src# /usr/bin/pdwtags.1.10-2.1build1 --verbose remote/.libs/libvirt_driver_remote_la-remote_protocol.o | grep -A5 '^enum remote_auth_type' die__process_unit: DW_TAG_restrict_type (0x37) @ <0x228> not handled! New: (bionic-amd64)root@Keschdeichel:/build/libvirt-OfdbiS/libvirt-4.0.0/debian/build/src# /usr/bin/pdwtags.1.21-0ubuntu1~18.04 --verbose remote/.libs/libvirt_driver_remote_la-remote_protocol.o | grep -A5 '^enum remote_auth_type' enum remote_auth_type { - REMOTE_AUTH_NONE = 0, - REMOTE_AUTH_SASL = 1, - REMOTE_AUTH_POLKIT = 2, + REMOTE_AUTH_NONE = 0, + REMOTE_AUTH_SASL = 1, + REMOTE_AUTH_POLKIT = 2, }; /* size: 4 */ Other use cases had valid output before, but now ware aligned - they might face similar FTFBS issues now. For libvirt I might fix the expected result or skip the test (as it always was skipped). But this update of dwarves has the potential to break much more users of it since not only the functionality but even the output style has changed by this update. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951438 Title: Update to 1.21-0ubuntu1~18.04 FTBFSes libvirt in-release To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dwarves-dfsg/+bug/1951438/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
