Thanks for working on this, Athos.
The debdiff looks good and I agree with the backports. I have also
verified that the package builds fine with the proposed changes +
openssl 3.
I just have some small requests before I proceed with the upload:
1) Could you add a period at the end of each changelog entry? I like to
treat them as sentences, and as such I consider that they should be
properly terminated.
2) Both patches should also have the "Bug-Ubuntu" DEP-3 header in order
to help determining why they're needed.
3) When I'm backporting multiple patches for a logical change like this,
I like writing a changelog entry like this:
* Fix FTBFS with OpenSSL 3. (LP: #1951952)
- d/p/add-SNI-support.patch: Add SNI support.
- d/p/do-not-force-tls-v1.patch: Do not enforce TLS v1.0 usage.
I think it looks more organized and is easier to understand that the
patches are part of something bigger.
If you could address these points, I can proceed with the upload right away.
Thanks again.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1951952
Title:
FTBFS - python-gear enforces TLSv1.0 usage
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-gear/+bug/1951952/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
