@Christian, I've written the MIR content to help moving things forward
but the owning team should probably be foundation since it's a
requirement from fwupd that they own.

From the MIR perspective those items need work

- the package doesn't include autopkgtests
- there is no debian/watch
- there are some lintian warnings


** Changed in: protobuf-c (Ubuntu)
       Status: Incomplete => New

** Description changed:

- The latest 1.7.x version of fwupd can use protobuf-c for supporting the
- flashing of Logitech devices that use logitech_bulkcontroller such as
- their 4k webcams.
+ [Availability]
+ The package protobuf-c is already in Ubuntu universe, and was in main some 
years ago.
+ The package protobuf-c builds for the architectures it is designed to work on.
+ It currently builds and works for architectures:  amd64 arm64 armhf i386 
ppc64el riscv64 s390x
+ Link to package https://launchpad.net/ubuntu/+source/protobuf-c
  
- This support has been disabled in Ubuntu since protobuf-c is not in main 
though.
- * See https://launchpad.net/ubuntu/+source/fwupd/1.7.1-1ubuntu3
+ [Rationale]
+ - The package protobuf-c is required in Ubuntu main for fwupd 1.7.x to handle 
firmware updates for Logitech devices that use logitech_bulkcontroller such as 
their 4k webcams.
+ - The feature is only going to be useful to users owning such hardware but it 
is important for those users.
  
- protobuf-c used to be in main (see bug
- https://bugs.launchpad.net/ubuntu/+source/protobuf-c/+bug/801735) but
- got downgraded to universe at some point.  Can we restore it to main?
+ [Security]
+ - No CVEs/security issues in this software in the past
+ 
+ - no `suid` or `sgid` binaries
+ - no executables in `/sbin` and `/usr/sbin`
+ - Package does not install services, timers or recurring jobs
+ - Packages does not open privileged ports (ports < 1024)
+ - Packages does not contain extensions to security-sensitive software
+ 
+ [Quality assurance - function/usage]
+ - The package works well right after install
+ 
+ [Quality assurance - maintenance]
+ - The package is maintained well in Debian/Ubuntu and has no bugs open in 
Debian or Ubuntu
+   - Ubuntu https://bugs.launchpad.net/ubuntu/+source/protobuf-c/+bug
+   - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=protobuf-c
+ - The package does not deal with exotic hardware we cannot support
+ 
+ [Quality assurance - testing]
+ - The package runs a test suite on build time, if it fails
+   it makes the build fail, link to build log 
https://launchpadlibrarian.net/464904971/buildlog_ubuntu-focal-amd64.protobuf-c_1.3.3-1_BUILDING.txt.gz
+ 
+ - The package does not run an autopkgtest but there is no reason they
+ shouldn't be added.
+ 
+ [Quality assurance - packaging]
+ - debian/watch is not present, no reason it shouldn't have one though
+ 
+ - This package has some minor lintian warnings
+ 
+ # lintian --pedantic
+ running with root privileges is not recommended!
+ W: protobuf-c-compiler: no-manual-page usr/bin/protoc-c
+ W: protobuf-c-compiler: no-manual-page usr/bin/protoc-gen-c
+ P: protobuf-c source: package-uses-old-debhelper-compat-version 12
+ P: protobuf-c source: silent-on-rules-requiring-root
+ P: protobuf-c source: update-debian-copyright 2019 vs 2020 
[debian/copyright:65]
+ 
+ and some warnings about long lines in upstream sources
+ 
+ - Lintian overrides are not present
+ 
+ - This package does not rely on obsolete or about to be demoted packages.
+ - This package has no python2 or GTK2 dependencies
+ 
+ - The package will be installed by default, but does not ask debconf
+ questions
+ 
+ - Packaging and build is easy, link to d/rules
+ https://salsa.debian.org/edmonds/protobuf-c/-/blob/master/debian/rules
+ 
+ [UI standards]
+ - Application is not end-user facing (does not need translation)
+ 
+ [Dependencies]
+ - No further depends or recommends dependencies that are not yet in main
+ 
+ [Standards compliance]
+ - This package correctly follows FHS and Debian Policy
+ 
+ [Maintenance/Owner]
+ - Owning Team should be foundations since they own fwupd
+ - Team is not yet, but will subscribe to the package before promotion
+ 
+ - This does not use static builds
+ - This does not use vendored code
+ 
+ [Background information]
+ The Package description explains the package well
+ Upstream Name is protobuf-c
+ Link to upstream project https://github.com/protobuf-c/protobuf-c

** Description changed:

  [Availability]
  The package protobuf-c is already in Ubuntu universe, and was in main some 
years ago.
  The package protobuf-c builds for the architectures it is designed to work on.
  It currently builds and works for architectures:  amd64 arm64 armhf i386 
ppc64el riscv64 s390x
  Link to package https://launchpad.net/ubuntu/+source/protobuf-c
  
  [Rationale]
  - The package protobuf-c is required in Ubuntu main for fwupd 1.7.x to handle 
firmware updates for Logitech devices that use logitech_bulkcontroller such as 
their 4k webcams.
  - The feature is only going to be useful to users owning such hardware but it 
is important for those users.
  
  [Security]
  - No CVEs/security issues in this software in the past
  
  - no `suid` or `sgid` binaries
  - no executables in `/sbin` and `/usr/sbin`
  - Package does not install services, timers or recurring jobs
  - Packages does not open privileged ports (ports < 1024)
  - Packages does not contain extensions to security-sensitive software
  
  [Quality assurance - function/usage]
  - The package works well right after install
  
  [Quality assurance - maintenance]
  - The package is maintained well in Debian/Ubuntu and has no bugs open in 
Debian or Ubuntu
-   - Ubuntu https://bugs.launchpad.net/ubuntu/+source/protobuf-c/+bug
-   - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=protobuf-c
+   - Ubuntu https://bugs.launchpad.net/ubuntu/+source/protobuf-c/+bug
+   - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=protobuf-c
  - The package does not deal with exotic hardware we cannot support
  
  [Quality assurance - testing]
  - The package runs a test suite on build time, if it fails
-   it makes the build fail, link to build log 
https://launchpadlibrarian.net/464904971/buildlog_ubuntu-focal-amd64.protobuf-c_1.3.3-1_BUILDING.txt.gz
+   it makes the build fail, link to build log 
https://launchpadlibrarian.net/464904971/buildlog_ubuntu-focal-amd64.protobuf-c_1.3.3-1_BUILDING.txt.gz
  
  - The package does not run an autopkgtest but there is no reason they
  shouldn't be added.
  
  [Quality assurance - packaging]
  - debian/watch is not present, no reason it shouldn't have one though
  
  - This package has some minor lintian warnings
  
  # lintian --pedantic
  running with root privileges is not recommended!
  W: protobuf-c-compiler: no-manual-page usr/bin/protoc-c
  W: protobuf-c-compiler: no-manual-page usr/bin/protoc-gen-c
  P: protobuf-c source: package-uses-old-debhelper-compat-version 12
  P: protobuf-c source: silent-on-rules-requiring-root
  P: protobuf-c source: update-debian-copyright 2019 vs 2020 
[debian/copyright:65]
  
  and some warnings about long lines in upstream sources
  
  - Lintian overrides are not present
  
  - This package does not rely on obsolete or about to be demoted packages.
  - This package has no python2 or GTK2 dependencies
  
  - The package will be installed by default, but does not ask debconf
  questions
  
  - Packaging and build is easy, link to d/rules
  https://salsa.debian.org/edmonds/protobuf-c/-/blob/master/debian/rules
  
  [UI standards]
  - Application is not end-user facing (does not need translation)
  
  [Dependencies]
  - No further depends or recommends dependencies that are not yet in main
  
  [Standards compliance]
  - This package correctly follows FHS and Debian Policy
  
  [Maintenance/Owner]
  - Owning Team should be foundations since they own fwupd
  - Team is not yet, but will subscribe to the package before promotion
  
  - This does not use static builds
  - This does not use vendored code
  
  [Background information]
  The Package description explains the package well
  Upstream Name is protobuf-c
  Link to upstream project https://github.com/protobuf-c/protobuf-c

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1956617

Title:
  [MIR] protobuf-c

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/protobuf-c/+bug/1956617/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to