------- Comment From wint...@de.ibm.com 2022-02-04 09:19 EDT-------
Actually the customer problem is fixed by the second part of the patch.
(alloc_page can issue warnings, but dev_alloc_page does not).

Would it be a solution to only backport the second part?
Are there any conventions how to document that in the commit header?

e.g. like this:
===================================================================
Author: Julian Wiedmann <j...@linux.ibm.com>
Date:   Wed Mar 18 13:54:45 2020 +0100

s390/qeth: use memory reserves to back RX buffers

Use dev_alloc_page() for backing the RX buffers with pages. This way we
pick up __GFP_MEMALLOC.

Signed-off-by: Julian Wiedmann <j...@linux.ibm.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
(cherry-picked from commit 714c9108851743bb718fbc1bfb81290f12a53854)
[__GFP_NOWARN for running devices]
Signed-off-by: Alexandra Winter <wint...@linux.ibm.com>

diff --git a/drivers/s390/net/qeth_core_main.c 
b/drivers/s390/net/qeth_core_main.c
index ec8c7a640d9e..e106db961c43 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -2612,7 +2612,7 @@ static struct qeth_buffer_pool_entry 
*qeth_find_free_buffer_pool_entry(
struct qeth_buffer_pool_entry, list);
for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
if (page_count(virt_to_page(entry->elements[i])) > 1) {
-                       page = alloc_page(GFP_ATOMIC);
+                       page = dev_alloc_page();
if (!page) {
return NULL;
} else {

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1959529

Title:
  Hipersocket page allocation failure on Ubuntu 20.04 based SSC
  environments

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1959529/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to