Review for Package: plocate
[Summary]
MIR team ACK, given the Required TODO is fixed, as it seems like a potential
big issue to me.
Notes:
Required TODOs:
- The source package can include binary content in obj-x86_64-linux-gnu/. Those
builds artefacts are included .exe and .o files. They are not present by
default on the source package, but nothing prevents really to accidentally
include them. I think it’s necessary to fix this and ensure we don’t embeed
them in our source files, as those are arch-dependant, binary code results
which would potentially override the one during the build due to a more recent
timestamp.
[Duplication]
This is a replacement of mlocate in main which provided the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- checked with check-mir
- not listed in seeded-in-ubuntu
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
- not a go package, no extra constraints to consider in that regard
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
[Common blockers]
OK:
- does not FTBFS currently
- does have a non-trivial test suite that runs as autopkgtest
- no new python2 dependency
Problems:
- does not have a test suite that runs at build time. However, some
autopkgtests are presents which covers then it.
[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under
control
- symbols tracking not applicable for this kind of code.
- d/watch is not present, but not needed
- Upstream update history is good (upstream is debian)
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list
Problems:
- The source package can include binary content in obj-x86_64-linux-gnu/. Those
builds artefacts are included .exe and .o files. They are not present by
default on the source package, but nothing prevents really to accidentally
include them. I think it’s necessary to fix this and ensure we don’t embeed
them in our source files, as those are arch-dependant, binary code results
which would potentially override the one during the build due to a more recent
timestamp.
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case
** Changed in: plocate (Ubuntu)
Status: New => Fix Committed
** Changed in: plocate (Ubuntu)
Assignee: Didier Roche (didrocks) => (unassigned)
** Changed in: plocate (Ubuntu)
Status: Fix Committed => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1960864
Title:
[MIR] plocate
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plocate/+bug/1960864/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
