Hi Simon, I updated the patch (attached) to reflect your findings on the FTBFS issue. I also built the package with the changes in a PPA at
https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp1964514-php- dapphp-radius-openssl3/+packages I will proceed to update this bug description to better reflect what has been discussed here and I will also go on and forward this patch to Debian. Note that I created a debian/NEWS entry to describe the issue so users know what to do to use the legacy providers. I did run the dep8 test suite locally, here is the test summary: autopkgtest [14:27:09]: @@@@@@@@@@@@@@@@@@@@ summary command1 PASS ** Patch added: "2-2.5.8-1ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/php-dapphp-radius/+bug/1964514/+attachment/5568015/+files/2-2.5.8-1ubuntu1.debdiff ** Summary changed: - FTBFS - test failures due to php 8 support missing + FTBFS - test failures due to disabled openssl 3 legacy providers ** Description changed: php-dapphp-radius currently FTBFS [1]. - The upstream patch included in the attached debdiff fixes the issue by - improving PHP 8 support in the package. + The attached patch fixes the build and dep8 tests by enabling the + OpenSSL 3 legacy provider through the OPENSSL_CONFIG environment + variable. - This was forwarded to Debian in https://salsa.debian.org/php- - team/pear/php-dapphp-radius/-/merge_requests/1. However, the package - does not FTBFS in Debian, most likely due to different build dependency - versions, namely, phpunit. Therefore, I´d like to include this delta for - jammy, which we can remove ince the package gets upgraded to 3.0.0 in - Debian or the linked salsa MR gets accepted. + The package does not FTBFS in Debian since debian have not shifted to + OpenSSL 3 yet. Therefore, I´d like to include this delta for jammy. Also note that there are no new features being introduced here. Hence, there should be no need for a FFe for this one. [1]: as per https://launchpadlibrarian.net/589175357/buildlog_ubuntu- jammy-amd64.php-dapphp-radius_2.5.8-1_BUILDING.txt.gz phpunit --include-path lib PHPUnit 9.5.10 by Sebastian Bergmann and contributors. ....F.F...F.S 13 / 13 (100%) Time: 00:00.006, Memory: 6.00 MB There were 3 failures: 1) ClientTest::testCryptCHAPMSv1 Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'5f169b7d8176516f8092bce99008e097febfed2f043ec04e' +'' /<<PKGBUILDDIR>>/tests/ClientTest.php:107 2) ClientTest::testCryptCHAPMSv2 Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'a3d12ce2f52d13fe04421205a2ce17b0e559ea8a9e594c1c' +'' /<<PKGBUILDDIR>>/tests/ClientTest.php:145 3) ClientTest::testMsChapV1Packet Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'01870082093e4ad125399f8ac4ba6b00ab69a04001066e656d6f04067f000001050600000014501248a3704ac91e8191497a1f3f213eb3381a10000001370b0a740c7921e45e91391a3a00000137013400010000000000000000000000000000000000000000000000004521bd46aebfd2ab3ec21dd6e6bbfa2e4ff325eab720fe37' +'0187006a093e4ad125399f8ac4ba6b00ab69a04001066e656d6f04067f0000010506000000145012467e2ad6e452c8bfbb8ca80ff167196e1a10000001370b0a740c7921e45e91391a2200000137011c0001000000000000000000000000000000000000000000000000' /<<PKGBUILDDIR>>/tests/ClientTest.php:246 FAILURES! Tests: 13, Assertions: 28, Failures: 3, Skipped: 1. make[1]: *** [debian/rules:21: override_dh_auto_test] Error 1 ** Changed in: php-dapphp-radius (Ubuntu) Status: Incomplete => In Progress ** Changed in: php-dapphp-radius (Ubuntu) Status: In Progress => Confirmed ** Changed in: php-dapphp-radius (Ubuntu) Assignee: Athos Ribeiro (athos-ribeiro) => Simon Chopin (schopin) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1964514 Title: FTBFS - test failures due to disabled openssl 3 legacy providers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php-dapphp-radius/+bug/1964514/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
