Thanks Lukas for the review, I think it should be ready to be considered again now
> Required TODOs: > #1 please run `update-maintainer` on the package, to update debian/control We will do in the next upload (if that's not a sync since we forwarded the autopkgtest to Debian), I don't think that's worth wasting buildds time by itself now. Ok with you? > #2 It is on the lto-disabled list (for s390x only). s390x is not supported by > upstream and FTBFS, so this entry should just be removed from the list. https://launchpad.net/ubuntu/+source/lto-disabled-list/26 > #3 does NOT have a test suite that runs at build time, and it only has one > simple autopkgtest (marked "superficial"). This does not fully check the > Q/A-testing requirements, IMO. Usually a proper autopkgtest would do, but > here the autopkgtest is minimal and we don't have build-time tests... > Are there any plans for end-to-end testing of the bluetooth codec/hardware? > Could a end2end test plan/code/log be provided or stated in the comments? We created a testplan for pipewire which includes a section specific to libldac/libfreeaptx, https://wiki.ubuntu.com/DesktopTeam/TestPlans/Pipewire > Recommended TODOs: > #4 The package should get a team bug subscriber before being promoted desktop-packages has been subscribed now > #5 build-time warnings should be resolved, working with upstream (see below) I didn't find a bugtracker for upstream (it's part of android) but for now I've reported it to Debian and we will see if we can provide a patch ** Changed in: libldac (Ubuntu) Status: Incomplete => New ** Changed in: libldac (Ubuntu) Assignee: (unassigned) => Lukas Märdian (slyon) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1973784 Title: [MIR] libldac To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libldac/+bug/1973784/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
