** Description changed: [ Impact ] In cloud-init 23.4, specifying a datasource via the SMBIOS is broken. This is due to a commit that fixed another bug of cloud-init assuming a datasource list consisting of one datasource and 'None' doesn't need to check for the existence of that datasource. The fix here is to ensure we're always checking for the SMBIOS information, whereas in the past we didn't need to because of the automatic datasource assumption. [ Test Plan ] An integration test has been added upstream as part of https://github.com/canonical/cloud-init/pull/4949 . This test fails if run against 23.4. If it passes, it demonstrates that the fix works. The test specifies an http datasource seed via SMBIOS and ensures that the userdata contained within that seed ran correctly. It can be run manually using: tox -e integration-tests -- tests/integration_tests/datasources/test_nocloud.py::test_smbios_seed_network [ Where problems could occur ] Since this code sits at the interaction of datasources discovered and found via ds-identify and python, along with bits of fallback code to dmidecode, we could have missed an interaction here that could possibly mis-identify the NoCloud datasource in other ways. [ Other Info ] + Upstream bug: https://github.com/canonical/cloud-init/issues/4945 + Upstream dup: https://github.com/canonical/cloud-init/issues/4951 + Documentation of specifying NoCloud datasource via SMBIOS : https://cloudinit.readthedocs.io/en/latest/reference/datasources/nocloud.html#method-2-local-filesystem-kernel-commandline-or-smbios Upstream PR with change that broke the cloud-init behavior: https://github.com/canonical/cloud-init/pull/4426 Upstream PR fixing the behavior: https://github.com/canonical/cloud-init/pull/4949
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055081 Title: NoCloud SMBIOS seed broken in 23.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/2055081/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
