NEW Review for mysql-shell:
After a bit of back and forth in my head I've found that what confused
me at first was that it has a MYSQL_VERSION file and a similar packaging
directory. But it has not full dir copy of mysql like percona had.
# namespace
source: the namespace is good, prefix with mysql- clearly assigns it to
where it belongs, it is not too short and thereby matches
upstream+project (which is just shell, which would have been conflicting
- but mysql-shell is fine)
binaries: only one also mysql-shell - OK
extracted content:
some of the project defined names are "mysqlsh" instead of mysql-shell, I
like the
longer more descriptive name in the package and do not see it as a conflict
to the extracted files.
At the same time we should not force the binary names names over to be not
the common way
-> OK
# FHS
- Some content in /usr/share/mysqlsh which is ok
- some extra doc content in /usr/share/doc/mysql-shell - ok
- I'm not so sure on the python packaging paths
/usr/lib/mysqlsh/plugins/...
/usr/lib/mysqlsh/python-packages/mysql_gadgets/...
/usr/lib/mysqlsh/python-packages/mysqlsh/...
are not in common paths
You'd usually expect /usr/lib/python3/dist-packages/... for any of that
Like:
/usr/lib/python3/dist-packages/mysqlsh/...
/usr/lib/python3/dist-packages/mysqlsh/plugins/....
Yet on the other hand those are not usual python files (libs or programs).
It is (by upstream) meant to go to libdir /usr/lib + name mysqlsh to be used
by their binary when in python scripting mode.
With that design it might be smart to not be in any normal include path.
And since it is only for internal usage by the tool itself, and for that FHS
says
about /usr/lib "Libraries for the binaries in /usr/bin and /usr/sbin."
So that is ok I think.
@anyone else please feel free to chime in and ensure a TIL moment for
me if that assumption is wrong.
# Dependencies
Test install in noble was fine, all dependencies were ok and I saw
nothing suspicious
# copyright
- Debian/* is GPL-3 + Canonical as it should be and it is new, not from
packaging/debian/*
- I did a full scan of copyrights and negative included what was defined, from
there I reduced one by one
and found the following worth a second look (fix it up or please reply where
my check was wrong):
- debian/additions/ConvertUTF*
LLVM is correct, but I think that should be "Copyright © 1991-2015 Unicode"
instead of "2003-2017 University of Illinois at Urbana-Champaign"
- ext/licenses/libssh-0.10.5-license.txt is in itself LGPL-2.1 which needs a
stanza for "1991, 1999
Free Software Foundation, Inc." as it in the source
- cmake/merge_archives_unix.cmake.in
2009 Sun Microsystems, Inc
This isn't generated, so let us list what is there (GPL-2)
- mysqlshdk/libs/utils/dtoa.cc
is "Oracle and/or its affiliates" whcih is the fallback, but also includes
"Copyright (c) 1991, 2000, 2001 by Lucent Technologies"
To be clear - A LOT was already correct, but these are a few easy to fix
improvement on the first upload IMHO.
# Packaging
- you have this as dfsg anyway so you seem to strip
But in ./ext/licenses/libssh-0.10.5/libssh-0.10.5.tar.xz is a non used
libssh.
Should that be removed as well to avoid any later issues?
Build uses libssh-dev in d/control.
Bonus: With that removed you could also drop the d/copyright stanza for
libssh wich is derived from what is in the LICENSES file
- tinyxml2 is in the archvie
tinyxml2 | 10.0.0+dfsg-2 | noble/universe | source
Could we strip ext/tinyxml2 as well and forget about licenses?
If not there are plentry of copyright statements in there missing in the
LICENSE file.
At least add those, but even better use tinyxml2 from the archive.
2 ext/tinyxml2-9.0.0/meson.build:1:# Copyright © 2020 Dylan Baker
3 ext/tinyxml2-9.0.0/docs/search/search.js:6: Copyright (C) 1997-2020 by
Dimitri van Heesch
4 ext/tinyxml2-9.0.0/docs/menu.js:6: Copyright (C) 1997-2020 by Dimitri van
Heesch
5 ext/tinyxml2-9.0.0/docs/jquery.js:6:* Copyright jQuery Foundation and other
contributors; Licensed MIT */
6 ext/tinyxml2-9.0.0/docs/jquery.js:10: * Copyright (c) 2007 Ariel Flesler -
aflesler ○ gmail • com | https://github.com/flesler
7 ext/tinyxml2-9.0.0/docs/jquery.js:19: Copyright (c) 2018 Steven Benner
(http://stevenbenner.com/).
8 ext/tinyxml2-9.0.0/docs/jquery.js:26: * Copyright 2011–2014, Dave Furfero
9 ext/tinyxml2-9.0.0/docs/jquery.js:35: * Copyright Vasil Dinkov, Vadikom Web
Ltd. http://vadikom.com; Licensed MIT */(function(t){"function"==typeof
define&&define.amd?define(["jquery"],t):"object"==typeof modu
10 ext/tinyxml2-9.0.0/docs/menudata.js:6: Copyright (C) 1997-2020 by Dimitri
van Heesch
11 ext/tinyxml2-9.0.0/meson_options.txt:1:# Copyright © 2020 Dylan Baker
- I'm not too happy about linenoise-ng being embedded (discontinued, but that
is for upstream to fix). At least this one would not be in the archive. related
interesting discussion
https://groups.google.com/g/linux.debian.bugs.dist/c/X4TP2fTpHDc
Nothing to be done on this one.
So overall, no hard-to-fix issues.
Maybe the case of tinyxml2, but in case this is really not doable please get in
contact and explain to consider it.
Other than that you have now the time until beta is released to fix this
up and then we can accept it as it is other than those minor things ok
AFAICS.
Assigning to Lena to fix those up ...
** Changed in: ubuntu
Assignee: (unassigned) => Lena Voytek (lvoytek)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2003316
Title:
[FFe] Please add mysql-shell to ubuntu
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2003316/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
