Hi Aleksandr -- thanks for the patch. There's a few things I'd like to
rectify, and a couple of questions which should probably be answered
before this can be sponsored. If we're going to introduce a delta on
Debian, we should ensure things are forwarded so the delta can be
resolved in time. To that end, the patches should have the Origin: or
Forwarded: tag so we can track what's been forwarded and where. Looking
through the patches added:

d/p/criu-fix-compatibility-with-python3-12.patch:
It would be preferable to add this as the two original patches it's made of so 
that each patch can have a simple Origin: header indicating where it came from 
(no need for Fowarded: in this case). Also, Author: should be Radostin (your 
name goes in d/changelog as the editor of the package, but Radostin is the 
author of the patch).

d/p/make-disable-Wformat-truncation-warning-with-gcc-13-2.patch:
Likewise, Author: should be Radostin. I'm a little confused about the origin of 
this patch. The referenced bug 
(https://github.com/checkpoint-restore/criu/issues/2398) has quite a different 
resolution upstream to the content of this patch 
(https://github.com/checkpoint-restore/criu/pull/2413/files). I'm guessing the 
upstream resolution is more recent; does the patch need revising?

d/p/time-t-64bit-transition-fixes.patch:
I'm assuming the Author: tag is correct here, as there's no other origin, but 
there's also no Forwarded: tag. Does this patch need forwarding upstream?

Finally, d/changelog currently references noble but I *suspect* this
will need to go into oracular first and then be SRU'd to noble (I've
requested clarification on #ubuntu-release, but I think this is the
procedure when something's been absent for more than one release).

Anyway, I'll unsubscribe ubuntu-sponsors for now, but please feel free
to add this back in if these points can be addressed.

** Bug watch added: github.com/checkpoint-restore/criu/issues #2398
   https://github.com/checkpoint-restore/criu/issues/2398

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2066148

Title:
  Ubuntu Noble lacks of CRIU package

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to