Thanks for the upload as well.

Ideally, the version should be `0.3.7-1ubuntu0.1` (not `ubuntu1`), as this
is for stable release (see [1]), but in this case it's fine -- the version
hasn't been used (see [2]), and will not be used anymore, as devel release
is already at `0.3.7-2`.

Now, I'd suggest the following _style_ changes, which helps Ubuntu maintenance
over time. This isnt' required, but is recommended and has been popularly used.

Changelog entry with related files:
  * d/p/05-Add-IBus-socket-access.patch: Fix non-functional keyboard (LP: 
#2056578).

DEP-3 tags in .patch file [3]:
  Bug-Ubuntu: https://bugs.launchpad.net/bugs/2056578
  Origin: vendor, 
https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/-/commit/fd38d605bc9160edaea2e5eaff665e550340f38e

Since the first point is fine in this case, and the remaining points are style,
this can be accepted as is into Noble.

Thanks for your contribution!
Mauricio

[1] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
[2] https://launchpad.net/ubuntu/+source/torbrowser-launcher/+publishinghistory
[3] https://dep-team.pages.debian.net/deps/dep3/

** Changed in: torbrowser-launcher (Ubuntu Noble)
       Status: Confirmed => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2056578

Title:
  [SRU - Noble] Tor Browser - keyboard not functioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/2056578/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to