Review for Source Package: libdex [Summary] MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does need a security review, so I'll assign ubuntu-security List of specific binary packages to be promoted to main: gir1.2-dex-1, libdex-1-1, libdex-dev, libdex-doc Specific binary packages built, but NOT to be promoted to main: <None>
Notes: Overall the package is in pretty good shape. The only problem is the absence of autpkg tests. However, the desktop team has worked around it, and has provided plans to test libdex in the context of sysprof : https://wiki.ubuntu.com/DesktopTeam/TestPlans/Sysprof https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeBuilder The current release is not packaged, the bug was opened before the latest release was released, and I guess it is in your plans to bump the version. With regards to @jbicha's concern on io_uring security, IMO this is mainly kernel's/liburing problem, but I agree that security could have a look to rule out any sideffects in this pacakge. Required TODOs: 1. Please bump to the latest upstream version 2. The package should get a team bug subscriber before being promoted [Rationale, Duplication and Ownership] There is no better alternative package in main providing the same functionality. A team (~desktop-packages) is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu [Dependencies] OK: - no other Dependencies to MIR due to this - libdex checked with `check-mir` - all dependencies can be found in `seeded-in-ubuntu` (already in main) - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have unexpected Built-Using entries - not a go package, no extra constraints to consider in that regard - not a rust package, no extra constraints to consider in that regard - Does not include vendored code Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, Problems: None [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - This does not need special HW for build or test - a non-trivial test on this level does not make sense (the lib alone is only doing rather simple things), the overall solution (app+libs) is tested accodring to https://wiki.ubuntu.com/DesktopTeam/TestPlans/Sysprof and https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeBuilder - no new python2 dependency Problems: - does not have a non-trivial test suite that runs as autopkgtest [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking is in place. - debian/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: - the current release is not packaged [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid / setgid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit or libseed - not part of the UI for extra checks - no translation present, but none needed for this case (user visible)? Problems: None ** Changed in: libdex (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => (unassigned) ** Changed in: libdex (Ubuntu) Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2066262 Title: [MIR] libdex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libdex/+bug/2066262/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
