Hi Chris, this generally looks good, but I have a couple of suggestions: * the patches are imported from git but have additional information added that doesn't really match https://dep- team.pages.debian.net/~/dep3/ - the Bug-Ubuntu and Origin fields would be ideal to link to the Ubuntu bug and the web location respectively and make it easier to compare the original commit to the actual patches
* we need a distinction in the version numbers between series, so I suggest modifying the Noble MPs to make that distinction, version 1.2.10-1ubuntu5.1 for alsa-ucm-conf on Noble for instance should suffice, and a similar change for firmware-sof, or there is a longer guide on version numbers at https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging * looks like Nick suggested kernel team review on the firmware-sof patches, and the above comments sound like these alsa-ucm-conf/firmware- sof uploads should happen around the same time, so it seems best to not upload alsa-ucm-conf for now pending that review * Question on the test cases - they mention manually installing a file from upstream, am I correct that this would be provided by the packaging or do we normally expect users to acquire that file from upstream? ** Merge proposal linked: https://code.launchpad.net/~mschiu77/ubuntu/+source/firmware-sof/+git/firmware-sof/+merge/468771 ** Merge proposal linked: https://code.launchpad.net/~mschiu77/ubuntu/+source/firmware-sof/+git/firmware-sof/+merge/467749 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2069760 Title: Soundwire support for CS42L43 and CS35L56 on Intel MTL To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2069760/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
