Packaging review:
MUST:
- Package must meet Ubuntu versioning & Maintainer requirements [OK]
Version: 1.4.2-0ubuntu1
Maintainer: Pushkar Kulkarni <[email protected]>
- Package must match current Ubuntu (and Debian) packaging policies [Comments]
See lintian clean section, warnings.
- Package must build, install, run, remove, and purge cleanly [OK]
SHOULD:
- Package should be lintian clean [Comments]
```
W: crac-criu source: absolute-symbolic-link-target-in-source
/usr/include/google/protobuf/descriptor.proto
[images/google/protobuf/descriptor.proto]
W: crac-criu source: build-depends-on-obsolete-package Build-Depends:
pkg-config => pkgconf
W: crac-criu: description-synopsis-starts-with-article
W: crac-criu source: globbing-patterns-out-of-order
lz4/lib/dll/example/Makefile lz4/lib/* lz4/lib/dll/example/Makefile
[debian/copyright:61]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not
defined [usr/share/man/man1/amdgpu_plugin.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not
defined [usr/share/man/man1/compel.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not
defined [usr/share/man/man1/crit.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not
defined [usr/share/man/man1/criu-ns.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not
defined [usr/share/man/man8/criu.8.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'HTML-TAG' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'HTML-TAG' not defined [usr/share/man/man1/compel.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'HTML-TAG' not defined [usr/share/man/man1/crit.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'HTML-TAG' not defined [usr/share/man/man1/criu-ns.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'HTML-TAG' not defined [usr/share/man/man8/criu.8.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'an-trap' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'an-trap' not defined [usr/share/man/man1/compel.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'an-trap' not defined [usr/share/man/man1/crit.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'an-trap' not defined [usr/share/man/man1/criu-ns.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'an-trap' not defined [usr/share/man/man8/criu.8.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'set-an-margin' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:1]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'set-an-margin' not defined [usr/share/man/man1/compel.1.gz:1]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'set-an-margin' not defined [usr/share/man/man1/crit.1.gz:1]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'set-an-margin' not defined [usr/share/man/man1/criu-ns.1.gz:1]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro
'set-an-margin' not defined [usr/share/man/man8/criu.8.gz:1]
W: crac-criu: link-to-shared-library-in-wrong-package
usr/lib/x86_64-linux-gnu/libcompel-crac.so.1.0
[usr/lib/x86_64-linux-gnu/libcompel-crac.so]
W: crac-criu: link-to-shared-library-in-wrong-package
usr/lib/x86_64-linux-gnu/libcriu-crac.so.2.0
[usr/lib/x86_64-linux-gnu/libcriu-crac.so]
W: crac-criu: no-manual-page [usr/bin/compel-crac]
W: crac-criu: no-manual-page [usr/sbin/criu-crac]
W: crac-criu: no-manual-page [usr/sbin/criu-ns-crac]
W: crac-criu: package-name-doesnt-match-sonames libcompel-crac1 libcriu-crac2
W: crac-criu source: patch-file-present-but-not-mentioned-in-series
[debian/patches/dont-install-man-pages.patch]
W: crac-criu source: superfluous-file-pattern lz4/lib/dll/example/Makefile
[debian/copyright:42]
W: crac-criu source: superfluous-file-pattern tests/frametest.c
[debian/copyright:70]
P: crac-criu source: debug-symbol-migration-possibly-complete
--ddeb-migration='criu-dbg (<< 1.8-2~)' [debian/rules:19]
P: crac-criu source: package-does-not-install-examples
[lz4/contrib/meson/meson/examples/]
P: crac-criu source: package-does-not-install-examples [lz4/examples/]
P: crac-criu source: source-contains-autogenerated-visual-c++-file
[lz4/build/VS2010/liblz4-dll/liblz4-dll.rc]
P: crac-criu source: source-contains-autogenerated-visual-c++-file
[lz4/build/VS2010/lz4/lz4.rc]
P: crac-criu source: source-contains-autogenerated-visual-c++-file
[lz4/build/VS2017/liblz4-dll/liblz4-dll.rc]
P: crac-criu source: source-contains-autogenerated-visual-c++-file
[lz4/build/VS2017/lz4/lz4.rc]
P: crac-criu source: source-contains-autogenerated-visual-c++-file
[lz4/build/VS2022/liblz4-dll/liblz4-dll.rc]
P: crac-criu source: trailing-whitespace [debian/control:4]
```
- Contents of debian/ should be sane [Comments]
d/rules do not need:
override_dh_strip:
dh_strip --ddeb-migration='criu-dbg (<< 1.8-2~)'
Consider fixing override_dh_auto_test or clarifying a comment why it is not
possible.
- Changelog should close a "needs-packaging" bug [OK]
- Package should follow
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html[OK]
Maintenance review:
MUST:
- Package must contain a watch file or get-orig-source rule [OK]
- If upstream is no more, the packager should consider adopting the upstream
package somewhere [N/A]
- Packages who implement get-orig-source for packages with watch files get
extra points [no extra points]
- Packaged version must not have any known security or critical bugs [OK]
See https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=criu, no current CVEs
SHOULD:
- Packaging scripts should be readable and readily comprehensible [OK]
- Upstream should be responsive, and maintain a bug tracker [OK]
- Packaged version should be latest upstream [OK]
- Package should not be native without an approved spec [N/A]
Suitability review
MUST:
- Package must meet copyright / licensing requirements [Comments]
debian/* - should we append Canonical 2024?
- Non-native packages must have verifiable cryptographic path to upstream
source [Comments]
See https://wiki.debian.org/debian/watch#Cryptographic_signature_verification.
We might want to add tag or release signing to our github repo.
- Package must be advocated by at least two members of ubuntu-dev (the packager
may count as one) [OK]
SHOULD:
- Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system
- Package should provide hints to system services (app-install-data, menus,
etc.) to ease installation and use [N/A]
- Package should provide Ubuntu-specific documentation for variances in
behaviour from upstream [Comments]
We may want to provide README.Debian to cover the changes from upstream CRIU.
- Package should provide a Homepage: header in debian/control [OK]
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2076037
Title:
[needs-packaging] crac-criu
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2076037/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
