** Description changed: + [ Impact ] + The Ubuntu Pro page uses a design that isn't consistent with the libadwaita design of the app. The text is not centered or using cards as expected, making it less appealing or looking as "professional" as ubuntu pro should. See also LP: #2062971 + + + [ Test case ] + + Ensure that ubuntu pro is detached, if not, use `pro detach` command. + + Run: + rm ~/.config/gnome-initial-setup-done + /usr/libexec/gnome-initial-setup --existing-user + + 1. Ubuntu Pro page should show after initial pages + - Pro should be suggested + - Navigating to next page or skipping the request should both work + - Note that using Alt+$KEY accelerators should work too + + 2. Attach page: + - Attaching a machine with a known token should work + - Attaching a machine with an external browser request should work + - Trying to attach with a wrong token should result in an error + - Going back to the offer page and back to the attach one should work, + generating a new magic token if required (time has expired). + + 3. Summary page: + - It should be shown only on success of the previous stage. + - An HiDPI scalable green check-mark should be shown to confirm the success. + - It should contain a bullet list of the activated services and a bullet list + of the available ones. + + + 4. Generic: + - In all the pages, the ubuntu pro logo should be centered, as well as the page + title. + - The page actions or highlights should be inside libadwaita-styled cards. + + + Running: + + env GTK_DEBUG=invert-text-dir /usr/libexec/gnome-initial-setup + --existing-user + + Should show all the list elements using the inverted (RTL) text direction, including: + - Pro benefits + - Pro enabled and disabled features + - Actions and their descriptions + + + [ Regression potential ] + + All the pro features in gnome-initial-setup may fail, so: + - Attaching a machine from token + - Attaching a machine from magic token (logging in from URI) + - Using a wrong token (should be refused) + - Going back and forth the pages + - The summary page should contain all the expected elements + + Note that this change implies some strings changes (not their contents, + but the way they're arranged), but this is not a problem for + translations because due to bug #2068639 we had no translations enabled + anyways. + + Also note that this follows the indications of the design team: + - https://warthogs.atlassian.net/browse/UDENG-3163
** Description changed: [ Impact ] The Ubuntu Pro page uses a design that isn't consistent with the libadwaita design of the app. The text is not centered or using cards as expected, making it less appealing or looking as "professional" as ubuntu pro should. See also LP: #2062971 - [ Test case ] Ensure that ubuntu pro is detached, if not, use `pro detach` command. Run: - rm ~/.config/gnome-initial-setup-done - /usr/libexec/gnome-initial-setup --existing-user + rm ~/.config/gnome-initial-setup-done + /usr/libexec/gnome-initial-setup --existing-user 1. Ubuntu Pro page should show after initial pages - - Pro should be suggested - - Navigating to next page or skipping the request should both work - - Note that using Alt+$KEY accelerators should work too + - Pro should be suggested + - Navigating to next page or skipping the request should both work + - Note that using Alt+$KEY accelerators should work too 2. Attach page: - - Attaching a machine with a known token should work - - Attaching a machine with an external browser request should work - - Trying to attach with a wrong token should result in an error - - Going back to the offer page and back to the attach one should work, - generating a new magic token if required (time has expired). + - Attaching a machine with a known token should work + - Attaching a machine with an external browser request should work + - Trying to attach with a wrong token should result in an error + - Going back to the offer page and back to the attach one should work, + generating a new magic token if required (time has expired). 3. Summary page: - - It should be shown only on success of the previous stage. - - An HiDPI scalable green check-mark should be shown to confirm the success. - - It should contain a bullet list of the activated services and a bullet list - of the available ones. - + - It should be shown only on success of the previous stage. + - An HiDPI scalable green check-mark should be shown to confirm the success. + - It should contain a bullet list of the activated services and a bullet list + of the available ones. 4. Generic: - - In all the pages, the ubuntu pro logo should be centered, as well as the page - title. - - The page actions or highlights should be inside libadwaita-styled cards. - + - The pages should have a consistent look with all the other pages of g-i-s + - In all the pages, the ubuntu pro logo should be centered, as well as the page + title and the contents. + - The page actions or highlights should be inside libadwaita-styled cards. Running: - env GTK_DEBUG=invert-text-dir /usr/libexec/gnome-initial-setup + env GTK_DEBUG=invert-text-dir /usr/libexec/gnome-initial-setup --existing-user Should show all the list elements using the inverted (RTL) text direction, including: - - Pro benefits - - Pro enabled and disabled features - - Actions and their descriptions - + - Pro benefits + - Pro enabled and disabled features + - Actions and their descriptions [ Regression potential ] All the pro features in gnome-initial-setup may fail, so: - - Attaching a machine from token - - Attaching a machine from magic token (logging in from URI) - - Using a wrong token (should be refused) - - Going back and forth the pages - - The summary page should contain all the expected elements + - Attaching a machine from token + - Attaching a machine from magic token (logging in from URI) + - Using a wrong token (should be refused) + - Going back and forth the pages + - The summary page should contain all the expected elements Note that this change implies some strings changes (not their contents, but the way they're arranged), but this is not a problem for translations because due to bug #2068639 we had no translations enabled anyways. Also note that this follows the indications of the design team: - - https://warthogs.atlassian.net/browse/UDENG-3163 + - https://warthogs.atlassian.net/browse/UDENG-3163 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2076189 Title: Ubuntu Pro page design is not consistent with the rest of the application To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-initial-setup/+bug/2076189/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
