In general this looks good.
> + * Backport upstream commit ecc44dffeb50746cc3e3019750226a80a50082a3
> + to fix test_ssh_leading_data with newer releases of Python
This sounds like it only affects tests, and thus is OK to add to the SRU
without further analysis. However, I was unable to verify this in a few
minutes, and you made no mention of it in the bug comments above. Are
you sure that this affects tests only and regular use of the built
binary package, and how can this be verified?
> [ Test Plan ]
> Try to install the patched package and verify that it still starts
> fine. Check that the warning is gone when installing or upgrading
> the package.
Please could you add a smoke test to the Test Plan, or if that is
already being done with automatic tests, document how you have
determined this? This would then help mitigate what you're already
identified in your regression analysis.
It would also be nice to have dep3 headers in the quilt patches so that
they can more easily be verified against upstream, but no need to re-
upload just for that.
** Changed in: kitty (Ubuntu Noble)
Status: In Progress => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2073688
Title:
/usr/lib/kitty/kitty/options/definition.py:4116: SyntaxWarning:
invalid escape sequence '\e' long_text='''
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kitty/+bug/2073688/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
