On Wed, 2024-08-14 at 16:57 +0000, Robie Basak wrote: > > > [ Test Plan ] > > > > > 1. Install python3-ironic: apt-get install python3-ironic > > 2. Check the file /usr/lib/python3/dist- > > packages/ironic/drivers/raid_config_schema.json is available > > > This is insufficient. The Impact statement says: > > > > The python3-ironic package available in Ubuntu Noble fails when trying > > to load the ironic drivers, because there is a json schema file missing. > > So in the Test Plan, please actually exercise the user story that > results in the failure, and check that the user story is successful.
I updated the test case to include the deployment and run of all the functional testing, this should not just validate the fix, but any potential regressions as well. ** Description changed: [Impact] The python3-ironic package available in Ubuntu Noble fails when trying to load the ironic drivers, because there is a json schema file missing. This is because the package is not including it when it was built. Stacktrace: 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service [None req-ee11f675-cc73-4c39-92d5-9a2ace917501 - - - - - -] Error starting thread.: ironic.common.exception.DriverLoadError: Driver, hardware type or interface no-raid could not be loaded. Reason: [Errno 2] No such file or directory: '/usr/lib/python3/dist-packages/ironic/drivers/raid_config_schema.json'. 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service Traceback (most recent call last): 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/stevedore/extension.py", line 206, in _load_plugins 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service ext = self._load_one_plugin(ep, 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/stevedore/named.py", line 156, in _load_one_plugin 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service return super(NamedExtensionManager, self)._load_one_plugin( 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/stevedore/extension.py", line 242, in _load_one_plugin 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service obj = plugin(*invoke_args, **invoke_kwds) 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/ironic/drivers/base.py", line 1461, in __init__ 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service with open(RAID_CONFIG_SCHEMA, 'r') as raid_schema_fobj: 2024-07-19 15:24:28.547 1009815 ERROR oslo_service.service FileNotFoundError: [Errno 2] No such file or directory: '/usr/lib/python3/dist-packages/ironic/drivers/raid_config_schema.json' - [ Test Plan ] - 1. Install python3-ironic: apt-get install python3-ironic - 2. Check the file /usr/lib/python3/dist- packages/ironic/drivers/raid_config_schema.json is available + 1. get a copy of charm-ironic-conductor: git clone https://opendev.org/openstack/charm-ironic-conductor + 2. Build a local copy of the charm: tox -e build + 3. Run the functional testing: cd src/ ; tox -e func-target -- noble-caracal + + + Expected results: All the tests passes + + Current result: /var/log/ironic/ironic-conductor.log has the error + logged "FileNotFoundError: [Errno 2] No such file or directory: + '/usr/lib/python3/dist-packages/ironic/drivers/raid_config_schema.json'" + [ Where problems could occur ] This change will make the python3-ironic package larger in size since it's including all files present in the released tarball, but not less. A possible issue could be that unused files are installed in the system, and this could be a problem for users producing OCI images, rocks and cheaseled images. [ Other Info ] This patch[0] was used to test this fix in jammy-caracal -> jammy- caracal-alt https://openstack-ci- reports.ubuntu.com/artifacts/6e7/924544/2/check/jammy-caracal- alt/6e746fb/ : SUCCESS in 59m 10s [0] https://review.opendev.org/c/openstack/charm-ironic- conductor/+/924544 ** Changed in: ironic (Ubuntu Noble) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2073643 Title: [Errno 2] No such file or directory: '/usr/lib/python3/dist- packages/ironic/drivers/raid_config_schema.json'. To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/2073643/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
