Hi Jorge and Mauricio, I will sponsor for oracular. The change looks
good to me overall, I just have a few notes:

Since the changes to the THANKS and Changelog files are not relevant to
the build, and the patch is already a backport due to line number
changes, I would recommend removing those portions for better patch
compatibility with future updates.

Mauricio also already mentioned changing Origin: upstream to Origin:
backport. I can change that too

Last minor note - in the changelog for the lp bug number I'd recommend
surrounding with parenthesis for formatting - (LP: #1953572). I've seen
some of our automation miss bug numbers in the past without them.

If you would like I can update the debdiff and sponsor, thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1953572

Title:
  Broken links in the View Trends and the View Histogram menu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nagios4/+bug/1953572/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to