Hello Robie, > This sounds like it only affects tests, and thus is OK to add to the SRU > without further analysis. However, I was unable to verify this in a few > minutes, and you made no mention of it in the bug comments above. Are you sure > that this affects tests only and regular use of the built binary package, and > how can this be verified?
No, it fixes something that will fail during testing and was caught by an upstream test that was run during build. The fix is an upstream cherry-pick that fixes that. It is not related to the SRU, but was asked to be added as well by Graham because the next SRU of Python would have broken it anyways. > Please could you add a smoke test to the Test Plan, or if that is already > being done with automatic tests, document how you have determined this? This > would then help mitigate what you're already identified in your regression > analysis. I added a list of commands in the test plan. As I said you just have to install the package and the warning is gone. Then I just use kitty as a regular terminal. > It would also be nice to have dep3 headers in the quilt patches so that they > can more easily be verified against upstream, but no need to re-upload just > for that. Yes. However I do not see my package anymore in -proposed. If I need to do a new upload, I can remove the git headers and use dep3 headers instead and propose a new debdiff for someone to sponsor. ** Description changed: [ Impact ] The package displays a warning when installing it or upgrading it from a previous version. This warning can scare users who see it in the terminal. [ Test Plan ] Try to install the patched package and verify that it still starts fine. Check that the warning is gone when installing or upgrading - the package. + the package: + + $ sudo dpkg -i ./kitty_xxx.deb # no warnings displayed during install + $ kitty # use as a terminal [ Where problems could occur ] Fixing the string wrongly can make the program behave wrongly. [ Original Bug Report ] Hello, During the upgrade of kitty, I get the following warning: Setting up kitty (0.32.2-1ubuntu0.1) ... /usr/lib/kitty/kitty/options/definition.py:4116: SyntaxWarning: invalid escape sequence '\e' long_text=''' I this this file should be patched so the warning does not appear during upgrade. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2073688 Title: /usr/lib/kitty/kitty/options/definition.py:4116: SyntaxWarning: invalid escape sequence '\e' long_text=''' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/kitty/+bug/2073688/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
