- SRU bug template: OK/FIX
 
This looks really good, but please:

Add a test step to ensure that a device bound to clevis 
_without_ the change (i.e., which used argon2id) _works_
_with_ the new change (which uses pbkdf2). 

That is, check for no regressions to existing users.

- d/changelog:

Version: OK
Series: OK
LP bug: OK
Author: OK

- d/p/0001-sss-use-BN_set_word-x-0-instead-of-BN_zero.patch: FIX

Unrelated noise; quilt refresh'ed this other patch too? 
Please do that only for the patch you're adding, on SRUs. Thanks!

- d/p/explicitly_specify_pbkdf_iterations_to_cryptsetup.patch:

Filename: OK/FIX

Optional, but helpful, please ad `lp<number>-` prefix to .patch
filename (even though it's present in .patch contents); it helps!

DEP3: look great, thanks!

BTW, you don't need `Author:` as you have `From:` with git patch.

Thanks again.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2073429

Title:
  Jammy clevis forces argon2id for keyslots

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/clevis/+bug/2073429/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to