Timo sponsored and asked for a New queue review:
# Managing the package namespace
src:ipu7-drivers
bin:intel-ipu7-dkms
Not too short and following the usual model for intel drivers that is already
used.
In fact it is the natural continuation of the former ipu7-drivers
=> OK
- Ensuring compliance with the software license
- The project itself is GPLv2 of Intel - that seems correct.
Also just 2024 is ok in this case
- Yet the packaging you created in debian/* should be GPLv3
That is the default of Canonical contributions,
While there is a policy that Canonical makes contributions
to upstream projects under the same license that the project
uses; Debian packaging is not a “contribution to an upstream
project”. debian/patches is an exception.
Due to that debian/* should please be:
Copyright: 2024, Canonical Ltd
License: GPL-3.0
=> Please fix this
# Ensuring correct component based on license
Should be ok to go to universe just like many similar PKGs.
=> universe/kernel
# basic packaging check
- This being after vision-drivers I was no more surprised by
using a git version and no debian watch file.
While in this case it would have been possible (upstream does
not have as complex version here) I ack that you'd want to
follow the same model in all these related packages.
Ack
- Standards could be 4.7.0, it is new why not start up to date?
Not a blocker though, but nice if fixed up on the next upload
- VCS- entries ought to be pointing at the package maintenance
So instead of
https://github.com/intel/ipu7-drivers.git
It should point at
https://code.launchpad.net/~vicamo/ubuntu/+source/ipu7-drivers/+git/ipu7-drivers
And furthermore, could it there be under a team and not a personal space?
This isn't a deep check, found improvement suggestions, but no red flags on a
quick pass.
=> OK
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2078326
Title:
[needs-packaging] ipu7-drivers
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2078326/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
