Hi Yuri, What is the regression risk for this patch?
** Description changed: - According to - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=88150cd9501b9498e377cc4440325267c6921f90, - Intel Arrow Lake IBECC(In-Band ECC)) feature is already added in - upstream. + [Impact] + Add Arrow Lake-U/H SoC compute die IDs for EDAC support. + + However, the OS scope in LENOVO are ubuntu 22.04 and 24.04 server + version, which are using Linux kernel 6.8, due to this reason, can this + feature be backport to these two version, thanks! + + [Test Plan] + + + [Fix] + According to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=88150cd9501b9498e377cc4440325267c6921f90, Intel Arrow Lake IBECC(In-Band ECC)) feature is already added in upstream. """"" author Qiuxu Zhuo <[email protected]> 2024-06-14 11:03:54 +0800 committer Tony Luck <[email protected]> 2024-06-14 08:08:12 -0700 commit 88150cd9501b9498e377cc4440325267c6921f90 (patch) tree fc574a0966af4f31dcc7247ff3fbbdcccffb1089 parent 123b158635505c89ed0d3ef45c5845ff9030a466 (diff) download linux-88150cd9501b9498e377cc4440325267c6921f90.tar.gz EDAC/igen6: Add Intel Arrow Lake-U/H SoCs support Arrow Lake-U/H SoCs share same IBECC registers with Meteor Lake-P SoCs. Add Arrow Lake-U/H SoC compute die IDs for EDAC support. Signed-off-by: Qiuxu Zhuo <[email protected]> Signed-off-by: Tony Luck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Diffstat - -rw-r--r-- drivers/edac/igen6_edac.c 8 + -rw-r--r-- drivers/edac/igen6_edac.c 8 1 files changed, 8 insertions, 0 deletions diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c index cdd8480e736877..c9fc1e64069e33 100644 --- a/drivers/edac/igen6_edac.c +++ b/drivers/edac/igen6_edac.c @@ -258,6 +258,11 @@ static struct work_struct ecclog_work; - #define DID_MTL_P_SKU2 0x7d02 - #define DID_MTL_P_SKU3 0x7d14 - + #define DID_MTL_P_SKU2 0x7d02 + #define DID_MTL_P_SKU3 0x7d14 + +/* Compute die IDs for Arrow Lake-UH with IBECC */ +#define DID_ARL_UH_SKU1 0x7d06 +#define DID_ARL_UH_SKU2 0x7d20 +#define DID_ARL_UH_SKU3 0x7d30 + - static int get_mchbar(struct pci_dev *pdev, u64 *mchbar) - { - union { + static int get_mchbar(struct pci_dev *pdev, u64 *mchbar) + { + union { @@ -597,6 +602,9 @@ static const struct pci_device_id igen6_pci_tbl[] = { - { PCI_VDEVICE(INTEL, DID_MTL_P_SKU1), (kernel_ulong_t)&mtl_p_cfg }, - { PCI_VDEVICE(INTEL, DID_MTL_P_SKU2), (kernel_ulong_t)&mtl_p_cfg }, - { PCI_VDEVICE(INTEL, DID_MTL_P_SKU3), (kernel_ulong_t)&mtl_p_cfg }, + { PCI_VDEVICE(INTEL, DID_MTL_P_SKU1), (kernel_ulong_t)&mtl_p_cfg }, + { PCI_VDEVICE(INTEL, DID_MTL_P_SKU2), (kernel_ulong_t)&mtl_p_cfg }, + { PCI_VDEVICE(INTEL, DID_MTL_P_SKU3), (kernel_ulong_t)&mtl_p_cfg }, + { PCI_VDEVICE(INTEL, DID_ARL_UH_SKU1), (kernel_ulong_t)&mtl_p_cfg }, + { PCI_VDEVICE(INTEL, DID_ARL_UH_SKU2), (kernel_ulong_t)&mtl_p_cfg }, + { PCI_VDEVICE(INTEL, DID_ARL_UH_SKU3), (kernel_ulong_t)&mtl_p_cfg }, - { }, - }; - MODULE_DEVICE_TABLE(pci, igen6_pci_tbl); + { }, + }; + MODULE_DEVICE_TABLE(pci, igen6_pci_tbl); """"" - However, the OS scope in LENOVO are ubuntu 22.04 and 24.04 server - version, which are using Linux kernel 6.8, due to this reason, can this - feature be backport to these two version, thanks! + + [Where problems could occur] + + [Other Info] + https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/noble/+ref/lp_2077861_intel_arrowlake_ibecc -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2077861 Title: [SRU]Intel Arrow Lake IBECC feature backport request for ubuntu 22.04.5 and 24.04.1 server To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2077861/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
