> 1. > There are spurious development artifacts being added

> I have looked through the debdiffs and couldn't find such, are you
referring to the "Maintainer" and "XSBC-Original-Maintainer" section
maybe?

Not the debdiffs, the actual upload. For example, from the Rejected
queue, http://launchpadlibrarian.net/745154626/powermgmt-
base_1.36_1.36ubuntu1.20.04.1.diff.gz contains:

> diff -Nru powermgmt-base-1.36/jammy-powermgmt.debdiff 
> powermgmt-base-1.36ubuntu1.20.04.1/jammy-powermgmt.debdiff
> --- powermgmt-base-1.36/jammy-powermgmt.debdiff       1970-01-01 
> 00:00:00.000000000 +0000
> +++ powermgmt-base-1.36ubuntu1.20.04.1/jammy-powermgmt.debdiff        
> 2024-08-12 14:17:10.000000000 +0000

...so debdiff files were being added to the source package upload.

> 2. > This does a glob expansion right here...

> Yes this is intended behavior as USBC is not the only USB power type,
it is also the same value used before my changes.

No I think you misunderstand. The script is running from some arbitrary
current directory. The result of `power_type="USB*"` depends on the
contents of that arbitrary current directory, which is probably not what
you intend. For example, if I happen to be in /home/racb/some_project/
when I run on_ac_power, and the file /home/racb/some_project/USB_gotcha
exists, then $power_type will get set to "USB_gotcha".

> 3. > Wouldn't that incorrectly identify the system as being on AC
power?

Thank you for the detailed reply! This is going to take some time to
read and understand. I'll reply to this separately so as not to lose
other replies above.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1980991

Title:
  /usr/sbin/on_ac_power incorrectly reporting ac power status

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/powermgmt-base/+bug/1980991/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to