@Steve: Some minor and less minor issues with your update:
1) you drop the hildon patch, can you explain why?
2) same question for the patch fix_desktop
Even if you have a good reason to drop patches, you need to mention why
in the changelog (usually the reason patches are dropped is because all
the fixes they carried were merged upstream).
3) I don't understand your comment "debian/docs removed as was blank":
could you clarify? I see some useful bits at the end of the upstream
README which could help people setup cheese with their hardware, I think
we should make sure people get the information in some way.
4) The upstream build changed a lot in 0.3.0: it wasn't autotools based
in the past, which made understanding the exact build-dependencies less
easy, and it seems the 0.2.4 packaging in Ubuntu was missing some build-
deps; this is however relatively easy to read in the new autoconf based
build, if you look at configure.ac, you should see e.g.
GLIB_REQUIRED=2.10.0 and then PKG_CHECK_MODULES(CHEESE, glib-2.0 >=
$GLIB_REQUIRED [...]), this means you need a libglib2.0-dev (>= 2.10.0)
build-dep (this package ships glib-2.0.pc). Could you please update the
build-dependencies to match the now more readable requirements in the
new upstream build system?
5) This is from the extra style points department: ;)
a) as an interdiff shows nicely, you added a spurious space in debian/rules
b) your changelog lists multiple different things together: you mention a new
upstream release on one line and then misc debian/control changes on another
line, such as updating build-deps and Standards-Version; instead, it would be
extra nice to list logical changes together, consider this:
* New upstream release
- Added build-deps on libxml-parser-perl and gnome-doc-utils for the
documentation build
- Added missing libglib2.0-dev (>= 2.10.0) build-dep
- Dropped TODO from debian/docs as this file isn't shipped upstream anymore.
* Bumped up Standards-Version to 3.7.3, no change needed.
this is just a suggestion, but I'm sure you'll find it quite natural in this
way!
c) your changelog mentions "many new upstream changes, see upstream NEWS" but
this isn't very helpful to readers; first, you don't actually install the NEWS
file, second, this isn't very helpful since if people don't read about the
upstream changes, they'll naturally look for the upstream changes!
Anyway, the 5th point is less important, it's much more about cosmetics
and style.
Cheers,
--
cheese new upstream version 0.3.0
https://bugs.launchpad.net/bugs/180624
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
