** Description changed:

  As noted in [1]  the ncurses version in Ubuntu noble (and presumably
  oracular, though I haven't checked this yet) breaks the (extremely
  useful) bulkrename command. The proposed fix in [2] works, but reading
  the associated thread [3] indicates it's possible that ranger is
  incorrectly calling curses.endwin() multiple times.
  
  That said, having read through the code I can't see where ranger *is*
- calling endwin() multiple times, and the purpose of the function that's
- failing (ui.suspend) is clearly to disable curses while an external
- application that wants the display (e.g. vim) is executed, so there's no
- harm in simply ignoring an error from curses.endwin().
+ calling endwin() multiple times [4], and the purpose of the function
+ that's failing (ui.suspend) is clearly to disable curses while an
+ external application that wants the display (e.g. vim) is executed, so
+ there's no harm in simply ignoring an error from curses.endwin().
  
  [1]: https://github.com/ranger/ranger/issues/2934
  
  [2]: https://github.com/ranger/ranger/pull/2935
  
  [3]: https://www.mail-archive.com/debian-bugs-
  [email protected]/msg1944374.html
+ 
+ [4]: bulkrename executes the external editor twice and it's the *second*
+ invocation that leads to the failure, which is presumably where endwin
+ is being called twice, but ui.initialize (which sets up curses all over
+ again) *is* being called between the two invocations ... which should be
+ valid?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2086744

Title:
  [SRU] bulkrename fails with newer curses

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ranger/+bug/2086744/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to