The orig tar-ball includes a full git repo?! WHYYYYYY?!!! Ahem. With
that horrific discovery off my chest, I shall continue...

This was (through no fault of Zixing's, I should note up front) an
absolute nightmare to review. Partly this was due to the aforementioned
presence of a full git repo in the orig tar-ball, so out went my usual
practice of using the git-ubuntu tree to diff things.

Secondly, the proposed patch is indeed minimal. Unfortunately, the
commit it purports to come from upstream does not match, because it is
anything but minimal. In fact, it's a vast commit encompassing literally
hundreds of changes. However, I've managed to pick it apart to determine
that the proposed patch is indeed a clean subset, and that it is
sufficient to make the package build in plucky.

So, I'm sponsoring this for plucky and may $deity have mercy on the soul
of whoever gets to review this next...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2083960

Title:
  gnome-subtitles FTBFS on Oracular

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-subtitles/+bug/2083960/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to