Public bug reported:

[ Impact ]

Upstream stable update v5.15.170 [1] for jammy introduces a backport of
upstream commit [2]

56440d7ec28d genetlink: hold RCU in genlmsg_mcast()

which drops the @flags parameter from function
genlmsg_multicast_allns(). The backport-iwlwifi module does not use its
compat implementation of that function when building against 5.15 but
links against what the kernel is providing. The build will consequently
fail with:

<<DKMSDIR>>/build/backport-iwlwifi/11510/build/net/wireless/nl80211.c: In 
function 'nl80211_common_reg_change_event':
<<DKMSDIR>>/build/backport-iwlwifi/11510/build/net/wireless/nl80211.c:17769:9: 
error: too many arguments to function 'genlmsg_multicast_allns'
17769 |         genlmsg_multicast_allns(&nl80211_fam, msg, 0,
      |         ^~~~~~~~~~~~~~~~~~~~~~~
In file included from 
<<DKMSDIR>>/build/backport-iwlwifi/11510/build/backport-include/net/genetlink.h:3,
                 from 
<<DKMSDIR>>/build/backport-iwlwifi/11510/build/net/wireless/nl80211.c:25:
./include/net/genetlink.h:342:5: note: declared here
  342 | int genlmsg_multicast_allns(const struct genl_family *family,
      |     ^~~~~~~~~~~~~~~~~~~~~~~

In order to build against the kernel with the modified function
signature of genlmsg_multicast_allns() we need to patch
net/wireless/nl80211.c that is shipped with backport-iwlwifi and drop
the now superfluous @flag parameter.

[ Test Plan ]

This issue can be reproduced by trying to build the dkms package against
a 5.15 kernel, e.g. jammy linux, with stable update v5.15.170 applied.

[ Where problems could occur ]

If at some point the compat implementation of the affected functionality
were to be used instead of what the kernel provides, the mismatch
between the calls in net/wireless/nl80211.c and the compat version of
genlmsg_multicast_allns() would cause the build to break again.

[ Other Info ]

[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2089272
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=56440d7ec28d60f8da3bfa09062b3368ff9b16db

** Affects: backport-iwlwifi-dkms (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: backport-iwlwifi-dkms (Ubuntu Jammy)
     Importance: High
     Assignee: Manuel Diewald (diewald)
         Status: In Progress

** Also affects: backport-iwlwifi-dkms (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Changed in: backport-iwlwifi-dkms (Ubuntu Jammy)
     Assignee: (unassigned) => Manuel Diewald (diewald)

** Changed in: backport-iwlwifi-dkms (Ubuntu Jammy)
   Importance: Undecided => High

** Changed in: backport-iwlwifi-dkms (Ubuntu Jammy)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2089385

Title:
  Fails to build against linux-5.15 after stable update

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2089385/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to