Hi Juerg,

While your debdiff is OK for a devel upload (with some improvements
possible ;-) ), SRUs are a slightly different beast, and I've seen
uploads rejected for some of the reasons outlined below.

The first and most important thing is that changes should be as minimal
as possible. Here, that means the 4th patch should be dropped as it is
unrelated to the actual bug and only creates noise.

Second, the version number should probably be 4.8.30-1ubuntu0.1 rather
than ...ubuntu1. While in this particular case it wouldn't be a problem
since Oracular shipped with a new version, it's a good habit to take.

Third, the patches could use some DEP-3 love: 
https://dep-team.pages.debian.net/deps/dep3/
I find the Origin, Forwarded and Applied-Upstream particularly helpful for 
ongoing maintenance.

And finally, the changelog could maybe be a bit verbose?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2062968

Title:
  mc (Midnight commander) not opening/navigating archives by enter

To manage notifications about this bug go to:
https://bugs.launchpad.net/mc/+bug/2062968/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to