I'm reviewing this in the Plucky NEW queue, some notes of minor issues/comments, none of those are blockers so I'm going to accept the upload now but you might want to do tweaks for the next upload
* Vcs - debian/control has Vcs-Git: https://github.com/raspberrypi/libpisp.git - debian/gbp.conf debian-branch=pios/bookworm but `pios/bookworm` doesn't seem to exist in the Vcs? * Standards-Version the package uses 4.6.2 where the current is 4.7.0.1, would be nice for a new package to not used an outdated Standards-Version * no tests/autopkgtest it would be nice to have a least a simple autopkgtest that build a small test program with the library to ensure the -dev depends are correct * debian/copyright it is a bit weird to include the license texts themself under license but ok * symbols the library doesn't have a .symbols which is against the best practice and will be require if you want it promoted to main later ** Changed in: ubuntu Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2089646 Title: [needs-packaging] libpisp To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2089646/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
