Review for the current version in ppa:r41k0u/raspi-utils:
TL;DR mostly good, I'm going to make some changes and sponsor, but most
are extremely nit-picky!
The upgrades are fixed, great! Standards, and architectures also fixed,
all good. All the lintian warnings are fixed, which is fantastic but I'm
going to make one major change here:
The warning about eepflash.sh is fixed by renaming it to eepflash.
There's two ways of doing this, and unfortunately the wrong one is
picked here which is to add a patch that removes the old binary and
inserts a new one. The reason this is a bad idea is that if the script
changes upstream the patch is now broken, and it's hard to verify that
the script being added by the patch matches the script removed. The
"right" way of doing this is to let the install phase happen as usual,
but override the filename afterwards. For example, in d/rules:
override_dh_auto_install:
dh_auto_install
mv debian/raspi-utils-eeprom/usr/bin/eepflash.sh
debian/raspi-utils-eeprom/usr/bin/eepflash
However, in this case I'd rather "not" fix it and just override the
lintian warning. While it's a bit ugly to have this one binary with a
.sh extension, it is upstream's choice and any guides covering the usage
of this tool on the internet will be referring to eepflash.sh (as will
any installed docs and manpages). So from that perspective I'd rather we
just override the warnings.
On the subject of lintian warning overrides, and this is entirely a nit-
pick of my own, I'm going to add a brief comment in the files covering
*why* the override is in place. Sometimes this is just to note a false-
positive, or just to document that we're actively following something
upstream are doing, but I like to have something next to an override so
future maintainers will know the reason we're suppressing a warning
instead of doing something else about it.
Other trivial nit-picks: no need to ship gbp.conf when it's not going to
point at anything useful for us, and I'm going to tweak the d/watch file
to use some of the substitutions like @PACKAGE@ and @ANY_VERSION@
because there's no need to hard-code that stuff.
Uploading with version adjusted to -0ubuntu1 suffix as this isn't
upstream in Debian so we need to ensure a version there can override
ours. Subscribing ubuntu-archive as this will hit the new queue.
Removing [FFe] prefix as that was left over from earlier cycles.
** Summary changed:
- [FFe][needs-packaging] raspi-utils (replacement for raspberrypi-userland)
+ [needs-packaging] raspi-utils (replacement for raspberrypi-userland)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2046250
Title:
[needs-packaging] raspi-utils (replacement for raspberrypi-userland)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/raspberrypi-userland/+bug/2046250/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
