Hi mikeaa,

no worries, your contribution is quite valuable! It's great to have a
view from a different perspective or use-case, as that helps us uncover
different scenarios of the bug to tackle.

For the other bugs you found, would you be able to open up a new report
for them? It makes tracking across different releases easier, as we'd
have a unique identifier per issue. Let's keep this one focused on the
leftover partition mounts; I think we have good enough evidence to point
out it's being caused by grub-probe terminating early, we just need to
figure out the best approach to fixing it :)

I'm uploading a v3 of my debdiff, as I missed one of the original parts
of the code that writes "fuseblk" to type if it's empty. This can
presumably happen when grub-probe does not error out, but returns an
empty string.

I still think we should follow existing code under os-probes for the
fix, and let LVM partitions be probed/mounted by later grub scripts (I'd
argue that booting from LVM snapshots is a net-positive, and probably
intended given the current code). I'm happy to defer to a more
experienced grub/os-prober developer on this matter and go with a
different fix if it makes more sense, though.

** Patch added: "lp1987679-plucky-v3.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1987679/+attachment/5855399/+files/lp1987679-plucky-v3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1987679

Title:
  os-prober leaves filesystems (lvm-thin, lvm snap) mounted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1987679/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to