Hey, Matthieu! Thank you for the patch!
The technical details of this patch look good. I do have some notes for the
changelog entry, though:
- Could you please carry over more from the 20.1.1-1ubuntu2 changelog entry?
Your changelog entry seems accurate, just a bit too concise given the details.
- This is subjective, but it's best practice to also detail the changes
dropped. To be clear, the formatting you have with "Merge with Debian;
Remaining changes:" is totally okay, but I'd write it as something like this:
```
* Merge from Debian Unstable. Remaining changes:
- [...]
* Dropped change, included in 20.1.1-1.1:
- debian/patches/fopen-on-arm.patch: don't use mlucas_fopen() for
system files.
```
- FWIW, the changelog spacing looks great this time. ;)
Could you please make these changes, provide a new diff, and re-
subscribe sponsors?
Please do feel free to reach out if you have any questions.
Thanks for your work here!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2098099
Title:
Please merge mlucas_20.1.1-1.3 from Debian unstable
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mlucas/+bug/2098099/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
