Nicely packaged! As discussed on MM there are a few nitpicks, but I'm happy to fix these up and sponsor this. The changes I've made (which I'll push separately as a PR to your upstream):
* d/changelog -- cut down to just the version sponsored. This should reflect the versions actually uploaded to the archive (and their corresponding releases) * d/crypto-config-docs.* -- removed as there is no crypto-config-docs section in d/control (yet) * d/crypto-config.manpages -- added to include the man-page in the built package * d/crypto-config.lintian-overrides -- added to override warnings about crypto-config-hijack.sh noting this is an interim measure * d/watch -- minor tidy-up to remove the ton of escapes * d/crypto-config.postinst is using /bin/bash. The "set -eu" in that script is fine under dash (/bin/sh) but not the "shopt -s inherit_errexit". Removed the latter and changed shebang to /bin/sh * d/crypto-config.triggers is using interest-await (the default) rather than interest-noawait. This *may* be intentional, but "interest-noawait" is generally preferred (per deb-triggers (5)) where the package is not "crucial" (in the sense of: failure of its triggers should prevent configuration of triggering packages) Sponsored for plucky with the aforementioned changes, unsubscribing ubuntu-sponsors, and subscribing ubuntu-archive as this will require AA review for new packages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2098879 Title: [needs-packaging] crypto-config in universe To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2098879/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
