** Description changed:

+ [ Impact ]
+ Due to an implementation detail, the output of `pro help` appears duplicate. 
All information is there, but the entries are being added to the output twice 
before it's printed.
+ The solution is a tweak to the code to check if an entry was already 
considered before adding it to the output again.
+ 
+ [ Test Plan ]
+ This is covered by the Pro Client acceptance tests, which will be executed as 
part of the validation of LP#2083973
+ 
+ [ Where problems could occur ]
+ 
+ Implementation errors like this, when not properly fixed, could lead to more 
noise in the `pro help` output.
+ We added the integration test there to make sure the output is shown as 
expected.
+ 
+ [ Original Description ]
  Hello, the output of `pro help` duplicates a lot of the lines:
  
  $ pro help
  usage: pro [-h] [--debug] [--version] <command> ...
  
  Quick start commands:
  
-   status           current status of all Ubuntu Pro services
-   status           current status of all Ubuntu Pro services
-   attach           attach this machine to an Ubuntu Pro subscription
-   attach           attach this machine to an Ubuntu Pro subscription
-   enable           enable a specific Ubuntu Pro service on this machine
-   enable           enable a specific Ubuntu Pro service on this machine
-   system           show system information related to Pro services
-   system           show system information related to Pro services
-   security-status  list available security updates for the system
-   security-status  list available security updates for the system
+   status           current status of all Ubuntu Pro services
+   status           current status of all Ubuntu Pro services
+   attach           attach this machine to an Ubuntu Pro subscription
+   attach           attach this machine to an Ubuntu Pro subscription
+   enable           enable a specific Ubuntu Pro service on this machine
+   enable           enable a specific Ubuntu Pro service on this machine
+   system           show system information related to Pro services
+   system           show system information related to Pro services
+   security-status  list available security updates for the system
+   security-status  list available security updates for the system
  
  Security-related commands:
  
-   fix              check for and mitigate the impact of a CVE/USN on this 
system
-   fix              check for and mitigate the impact of a CVE/USN on this 
system
+   fix              check for and mitigate the impact of a CVE/USN on this 
system
+   fix              check for and mitigate the impact of a CVE/USN on this 
system
  
  Troubleshooting-related commands:
  
-   collect-logs     collect Pro logs and debug information
-   collect-logs     collect Pro logs and debug information
+   collect-logs     collect Pro logs and debug information
+   collect-logs     collect Pro logs and debug information
  
  Other commands:
  
-   api              Calls the Client API endpoints.
-   auto-attach      automatically attach on supported platforms
-   config           manage Ubuntu Pro configuration on this machine
-   detach           remove this machine from an Ubuntu Pro subscription
-   disable          disable a specific Ubuntu Pro service on this machine
-   refresh          refresh Ubuntu Pro services
-   api              Calls the Client API endpoints.
-   auto-attach      automatically attach on supported platforms
-   config           manage Ubuntu Pro configuration on this machine
-   detach           remove this machine from an Ubuntu Pro subscription
-   disable          disable a specific Ubuntu Pro service on this machine
-   refresh          refresh Ubuntu Pro services
+   api              Calls the Client API endpoints.
+   auto-attach      automatically attach on supported platforms
+   config           manage Ubuntu Pro configuration on this machine
+   detach           remove this machine from an Ubuntu Pro subscription
+   disable          disable a specific Ubuntu Pro service on this machine
+   refresh          refresh Ubuntu Pro services
+   api              Calls the Client API endpoints.
+   auto-attach      automatically attach on supported platforms
+   config           manage Ubuntu Pro configuration on this machine
+   detach           remove this machine from an Ubuntu Pro subscription
+   disable          disable a specific Ubuntu Pro service on this machine
+   refresh          refresh Ubuntu Pro services
  
  Flags:
  
-   -h, --help       Displays help on pro and command line options
-   --debug          show all debug log messages to console
-   --version        show version of pro
-   -h, --help       Displays help on pro and command line options
-   --debug          show all debug log messages to console
-   --version        show version of pro
+   -h, --help       Displays help on pro and command line options
+   --debug          show all debug log messages to console
+   --version        show version of pro
+   -h, --help       Displays help on pro and command line options
+   --debug          show all debug log messages to console
+   --version        show version of pro
  
  Use pro <command> --help for more information about a command.
- 
  
  Thanks
  
  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: ubuntu-pro-client 34~20.04
  ProcVersionSignature: Ubuntu 5.4.0-200.220-generic 5.4.284
  Uname: Linux 5.4.0-200-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu27.27
  Architecture: amd64
  CasperMD5CheckResult: skip
  Date: Mon Dec  9 23:57:37 2024
  SourcePackage: ubuntu-advantage-tools
  UpgradeStatus: Upgraded to focal on 2020-01-24 (1781 days ago)
  apparmor_logs.txt:
-  
+ 
  cloud-id.txt-error: Invalid command specified 'cloud-id'.
  jobs-status.json: {"metering": {"last_run": 
"2024-12-09T19:38:47.627652+00:00", "next_run": 
"2024-12-09T23:38:47.627652+00:00"}, "update_messaging": {"last_run": 
"2024-12-09T19:38:47.627652+00:00", "next_run": 
"2024-12-10T01:38:47.627652+00:00"}, "validate_release_series": {"last_run": 
"2024-12-09T13:12:51+00:00", "next_run": "2024-12-10T13:12:51+00:00"}}
  mtime.conffile..etc.logrotate.d.ubuntu-pro-client: 2022-04-18T17:07:59.892148
  uaclient.conf:
-  contract_url: https://contracts.canonical.com
-  log_level: debug
+  contract_url: https://contracts.canonical.com
+  log_level: debug
  ubuntu-advantage.log:

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2091327

Title:
  duplicated lines in help output

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2091327/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to