** Description changed: - ubuntu-pro-client has an unnecessary dependency on python3-pkg- - resources, at least grepping the source for pkg_resources doesn't show - anything. Please remove it. + [ Impact ] + The Client had an unnecessary dependency on python3-pkg-resources. This was bringing in many unwanted dependencies to seeds after Oracular. + + There is a code snippet autogenerated by setuptools which imports + pkg_resources, and that is actually needed up to Focal. Jammy and + greater only rely on pkg_resources as a fallback to importlib - which + does not justify it's inclusion as a depndency. + + This was fixed in Oracular by just removing the dependency in version + 34.1. However, that change would potentially break Xenial, Bionic and + Focal. So, for version 35, a new patch has been applied, implementing a + conditional dependency on the package. + + As of v35, the pro client will keep depending on pkg-resources up to + Noble, but not for any subsequent release. + + [ Test Plan ] + As the dependency was used directly in /usr/bin/pro, all pro commands must work after the patch exactly the same. + Thus, it's possible to claim that the acceptance tests that will be considered as validation for #2083973 also cover this bug. + Adittionally, on Oracular, we can verify that ubuntu-pro-client is installed and the dependency is not there, using `apt show`. + + [ Where problems could occur ] + As this is a conditional dependency, mistakes in the implementation could lead to: + - python3-pkg-resources being present as a dependency on Oracular+ : which would bring more dependencies as explained above + - python3-pkg-resources being absent as a dependency on -Focal: which would break /usr/bin/pro. This is covered by the integration test suite. + + [ Original Description ] + ubuntu-pro-client has an unnecessary dependency on python3-pkg-resources, at least grepping the source for pkg_resources doesn't show anything. Please remove it.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2083665 Title: ubuntu-pro-client has an unnecessary dependency on python3-pkg- resources To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2083665/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
