** Description changed:

+ [ Impact ]
+ 
+ Upstream kernel API changes in v6.13. The details can be found in the
+ below.
+ 
+ The solution to the two API changes is to upgrade backport-iwlwifi to
+ core93 in bug 2098677 as it becomes available, and to add backward
+ compatible implementation for the kernel headers.
+ 
+ [ Test Plan ]
+ 
+ 1. Install kernel v6.13 headers. Currently it is only available through
+ prebuilt headers packages in https://kernel.ubuntu.com/mainline/.
+ 
+ 2. Install backport-iwlwifi-dkms from plucky-proposed.
+ 
+ 3. The dkms should be compiled automatically with the running kernel. To
+ compile it against the just installed v6.13 kernels:
+ 
+ ```
+ $ for k in $(dpkg -l| awk '$2 ~ /^linux-headers-.*-generic$/ { print 
substr($2, length("linux-headers-") + 1); }'|sort -V -r); do sudo dkms install 
--force backport-iwlwifi/0~93.12955-gite723a6f0 -k $k || break; done
+ ```
+ 
+ [ Where problems could occur ]
+ 
+ The adaption layer was done to provide API compatibility with previously
+ released kernels. The upstream change may be depending on some
+ implicitly related fixes, but it doesn't seem to be the case for this
+ update.
+ 
+ [ Other Info ]
+ 
+ Only nominate for Plucky because that's only available in Plucky (now
+ 6.14).
+ 
+ ========== original bug report ==========
+ 
  * implicit declaration of function ‘pcim_iomap_regions_request_all’:
  
  drivers/net/wireless/intel/iwlwifi/pcie/trans.c: In function 
‘iwl_trans_pcie_alloc’:
  drivers/net/wireless/intel/iwlwifi/pcie/trans.c:3717:15: error: implicit 
declaration of function ‘pcim_iomap_regions_request_all’ 
[-Wimplicit-function-declaration]
   3717 |         ret = pcim_iomap_regions_request_all(pdev, BIT(0), DRV_NAME);
        |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  make[9]: *** 
[/usr/src/linux-headers-6.13.0-061300rc1-generic/scripts/Makefile.build:194: 
drivers/net/wireless/intel/iwlwifi/pcie/trans.o] Error 1
  make[9]: *** Waiting for unfinished jobs....
  
  v6.13-rc1 commit 6d9c59212523e ("PCI: Remove
  pcim_iomap_regions_request_all()") removed the deprecated call, and the
  replacement was done in v6.13-rc1 commit 3dd6ed25a90cf ("wifi: iwlwifi:
  replace deprecated PCI functions"). In the transition, same v6.13-rc1
  commit d9d959c36bec5 ("PCI: Make pcim_request_all_regions() a public
  function") is a prerequisite.
  
  * symbol namespace converted to string literal:
  
  /tmp/ccVJUOIr.s: Assembler messages:
  /tmp/ccVJUOIr.s:7: Error: junk at end of line, first unrecognized character 
is `I'
  ...
  make[9]: *** 
[/usr/src/linux-headers-6.14.0-2-generic/scripts/Makefile.build:207: 
drivers/net/wireless/intel/iwlwifi/iwl-io.o] Error 1
  
  In file included from 
/home/vicamo/work/canonical/dkms/iwlwifi/backport-iwlwifi-dkms/backport-include/linux/moduleparam.h:3,
-                  from 
/usr/src/linux-headers-6.14.0-2-generic/include/linux/module.h:22,
-                  from 
/home/vicamo/work/canonical/dkms/iwlwifi/backport-iwlwifi-dkms/backport-include/linux/module.h:3,
-                  from drivers/net/wireless/intel/iwlwifi/mvm/ops.c:7:
+                  from 
/usr/src/linux-headers-6.14.0-2-generic/include/linux/module.h:22,
+                  from 
/home/vicamo/work/canonical/dkms/iwlwifi/backport-iwlwifi-dkms/backport-include/linux/module.h:3,
+                  from drivers/net/wireless/intel/iwlwifi/mvm/ops.c:7:
  drivers/net/wireless/intel/iwlwifi/mvm/ops.c:45:18: error: expected ',' or 
';' before 'IWLWIFI'
-    45 | MODULE_IMPORT_NS(IWLWIFI);
-       |                  ^~~~~~~
+    45 | MODULE_IMPORT_NS(IWLWIFI);
+       |                  ^~~~~~~
  /usr/src/linux-headers-6.14.0-2-generic/include/linux/moduleparam.h:26:61: 
note: in definition of macro '__MODULE_INFO'
-    26 |                 = __MODULE_INFO_PREFIX __stringify(tag) "=" info
-       |                                                             ^~~~
+    26 |                 = __MODULE_INFO_PREFIX __stringify(tag) "=" info
+       |                                                             ^~~~
  /usr/src/linux-headers-6.14.0-2-generic/include/linux/module.h:299:33: note: 
in expansion of macro 'MODULE_INFO'
-   299 | #define MODULE_IMPORT_NS(ns)    MODULE_INFO(import_ns, ns)
-       |                                 ^~~~~~~~~~~
+   299 | #define MODULE_IMPORT_NS(ns)    MODULE_INFO(import_ns, ns)
+       |                                 ^~~~~~~~~~~
  drivers/net/wireless/intel/iwlwifi/mvm/ops.c:45:1: note: in expansion of 
macro 'MODULE_IMPORT_NS'
-    45 | MODULE_IMPORT_NS(IWLWIFI);
-       | ^~~~~~~~~~~~~~~~
+    45 | MODULE_IMPORT_NS(IWLWIFI);
+       | ^~~~~~~~~~~~~~~~
  
  See v6.13-rc2 commits cdd30ebb1b9f ("module: Convert symbol namespace to
  string literal") and ceb8bf2ceaa7 ("module: Convert default symbol
  namespace to string literal").

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2095140

Title:
  Failed to build against v6.13

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/2095140/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to