Review for Source Package: glycin [Summary]
The package is in good shape. One imprortant bug open in debian (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1099233) but seems to be resolved now. Owning team is already working on autopapkgtest and rust craft vendoring. Even though check-mir does not report it, it seems glycin-loaders depends on libjxl: $ apt info glycin-loaders ... Depends: libc6 (>= 2.39), libcairo2 (>= 1.4.10), libgcc-s1 (>= 4.2), libglib2.0-0t64 (>= 2.16.0), libheif1 (>= 1.13.0), libjxl0.11 (>= 0.7.0), librsvg2-2 (>= 2.52.5) ... jpeg-xl, source package for libjxl is not yet in main but under MIR review : https://bugs.launchpad.net/ubuntu/+source/jpeg-xl/+bug/2070882 MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does need a security review, the security-team has already this under their radar. Therefore, I'll assign bug reporter to address the feedback of review. After the TODOs are resolved, security-team shall be assgined if need be. List of specific binary packages to be promoted to main: glycin-loaders Specific binary packages built, but NOT to be promoted to main: <None> Notes: Required TODOs: 1. Need to add autopackage tests 2. Vendor rust dependencies 3. Depends on jpeg-xl : https://bugs.launchpad.net/ubuntu/+source/jpeg-xl/+bug/2070882 - The package already has a team bug subscriber [Rationale, Duplication and Ownership] There is no other package in main providing the same functionality. A team is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu [Dependencies] OK: - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: - other Dependencies to MIR due to this [Embedded sources and static linking] OK: - no static linking - does not have unexpected Built-Using entries Problems: - Rust package does not have all dependencies vendored [Security] OK: TODO: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) - this makes appropriate (for its exposure) use of established risk mitigation features (dropping permissions, using temporary environments, restricted users/groups, seccomp, systemd isolation features, apparmor, ...) Problems: - does parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - This does not need special HW for build or test - no new python2 dependency Problems: - does not have a non-trivial test suite that runs as autopkgtest [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking not applicable for this kind of code. - debian/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no incautious use of malloc/sprintf (the language has no direct MM) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid / setgid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit or libseed - not part of the UI for extra checks - no translation present, but none needed for this case (user visible)? Problems: - several warnings during the build ** Bug watch added: Debian Bug tracker #1099233 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1099233 ** Changed in: glycin (Ubuntu) Status: New => Incomplete ** Changed in: glycin (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => (unassigned) ** Changed in: glycin (Ubuntu) Assignee: (unassigned) => Sebastien Bacher (seb128) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2093182 Title: [MIR] glycin To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/glycin/+bug/2093182/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
