Hi Chengen, Below is my initial review of the patches. I think there is a lot that can be done here to simplify and reduce noise, so that only the critical logic changes are included.
> lp2100252-0001-sd-device-introduce-sd_device_new_from_devname.patch 1. The sd_device_new_from_path() function is never use. Please drop that change. 2. Let's not add sd_device_new_from_devname() to the public API here. While that is the upstream change, I would like to avoid adding symbols to libsystemd in this SRU. Instead, please move the function to src/libsystemd/sd-device/device-private.c, and call it device_new_from_devname() or so. > lp2100252-0002-core-device-store-the-original-path.patch I think this patch is fine as-is. It's a preparation commit, and is required for the real changes later. > lp2100252-0003-core-device-move-several-functions.patch This patch appears to just move code around. Is this needed at all? If it is needed to compile correctly, can this instead be accomplished with forward declarations? That would be a far less noisy patch. > lp2100252-0004-core-device-always-accept-syspath-change.patch This seems reasonable from a first glance, but I will take a closer look on a later review. Also, it's up to you, but note that we do manage the systemd packaging in git at https://git.launchpad.net/~ubuntu-core- dev/ubuntu/+source/systemd. It may be more convenient for review purposes to open PRs, rather than using debdiffs. ** Changed in: systemd (Ubuntu Focal) Status: In Progress => Incomplete ** Changed in: systemd (Ubuntu Jammy) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2100252 Title: A reused mount point is removed after deactivating the original volume group To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/2100252/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
