Feedback for Joshua:

I have attached the final jammy/yoga debdiff for you to study. The same things
apply since when I last sponsored your octavia upload.

- debian/changelog: You need to describe your change and then follow with the
patch file, instead of just having a single line of the patch file. The
description I wrote is:

* Under heavy load, OVN metadata notifications can be held up
  leading to ovsdb-server merging insert and update notifications.
  This can lead to metadata port being missing for some VMs which
  breaks connectivity, e.g. missing DHCP leases. (LP: #2017748)
  - d/p/lp2017748-handle-creation-of-Port_Binding-with-chassis-set.patch
  
- I renamed the patch to 
"lp2017748-handle-creation-of-Port_Binding-with-chassis-set.patch"
to put the lp bug number infront of it.

- I refreshed the patch, and moved the dep3 tags to under the Subject block.
I also indented the Subject block to match dep3 requirements.

As for the SRU template, I think you really need to be more descriptive of what
the change does, e.g. the impact section needs to be more than one line of

> ovnmeta- namespaces are missing intermittently then can't reach to VMs

I sponsored for now due to the original description having the necessary
details for the SRU Team to make an informed decision. 

For the "where problems could occur" section, I think you really need to 
consider
the impact to users if a regression were to occur, and what symptoms users would
likely see, and how they might be able to correct it / workaround it.

** Patch added: "Final debdiff for jammy/yoga"
   
https://bugs.launchpad.net/ubuntu/+source/neutron/+bug/2017748/+attachment/5872269/+files/lp2017748_jammy.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2017748

Title:
  [SRU] OVN:  ovnmeta namespaces missing during scalability test causing
  DHCP issues

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2017748/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to