** Description changed:

+ [ Impact ]
+ 
+  * Onionshare is completely broken on Noble and Oracular as it crashes when 
the server is started.
+  * Plucky and Questing are not affected as this issue got fixed when the 
package was synced from Debian on Plucky.
+ 
+ [ Test Plan ]
+ 
+  * start onionshare (for example by running `onionshare-cli foobar.txt`)
+ and verify that it can connect to tor.
+ 
+ [ Where problems could occur ]
+ 
+  * This patch could introduce another regression that might have been 
undetected until now because the server wouldn't even start.
+  * More changes might be needed to fully migrate to python3.12.
+ 
+ [ Original Bug Description ]
+ 
  Source package: onionshare
  
  1) Ubuntu release version:
  Description:  Ubuntu 24.04.2 LTS
  Release:      24.04
  
  2) Version of the package:
  onionshare:
-   Candidate: 2.6-6ubuntu1
-   Version table:
-      2.6-6ubuntu1 500
-         500 http://archive.ubuntu.com/ubuntu noble/universe amd64 Packages
+   Candidate: 2.6-6ubuntu1
+   Version table:
+      2.6-6ubuntu1 500
+         500 http://archive.ubuntu.com/ubuntu noble/universe amd64 Packages
  
  3) What I expected to happen: Onionshare is able to start after
  connecting to the Tor network.
  
  4) What happened instead:
  
  After connecting to the Tor network, Onionshare crashes:
  
  ```
  Connecting to the Tor network: 100% - Done
  Traceback (most recent call last):
-   File "/usr/lib/python3/dist-packages/onionshare/tor_connection.py", line 
180, in run
-     self.parent.onion.connect(self.settings, False, self._tor_status_update)
-   File "/usr/lib/python3/dist-packages/onionshare_cli/onion.py", line 661, in 
connect
-     self.supports_v3_onions = self.tor_version >= Version("0.3.5.7")
-                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   File "/usr/lib/python3/dist-packages/onionshare/tor_connection.py", line 
180, in run
+     self.parent.onion.connect(self.settings, False, self._tor_status_update)
+   File "/usr/lib/python3/dist-packages/onionshare_cli/onion.py", line 661, in 
connect
+     self.supports_v3_onions = self.tor_version >= Version("0.3.5.7")
+                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  TypeError: '>=' not supported between instances of 'str' and 'Version'
  ```
  
  Corresponding GitHub issue with response from maintainer:
  <https://github.com/onionshare/onionshare/issues/2025>
  
  Specifically:
  
  > I think the Ubuntu maintainers accidentally introduced this bug in
  their last change (see latest changelog entry at
  
https://changelogs.ubuntu.com/changelogs/pool/universe/o/onionshare/onionshare_2.6-6ubuntu1/changelog
  "Use packaging.version instead of distutils.version.")

** Changed in: onionshare (Ubuntu)
       Status: Confirmed => Fix Released

** Changed in: onionshare (Ubuntu Noble)
       Status: New => Confirmed

** Changed in: onionshare (Ubuntu Oracular)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2103668

Title:
  Onionshare fatally crashes after Tor connection (fix seems easy)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/onionshare/+bug/2103668/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to