Hi, Thanks for all the above work. Simon meant to expand the [Test Plan] section above. Your example looks reasonable, so I will update the description with that information.
The debdiff looks good to me as well, and has general approval above. I will upload this to Jammy now. Note that I made one small adjustment: I added Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/sysdig/+bug/2114822 to the patch header. This is preferred because it gives another specific pointer back to the bug report that the patch is addressing. Thanks! ** Description changed: [ Impact ] sysdig-dkms FTBFS in Jammy on arm64 as follows: make: Entering directory '/usr/src/linux-headers-5.15.0-141-generic' 4 CC [M] /var/lib/dkms/sysdig/0.27.1/build/main.o 5 CC [M] /var/lib/dkms/sysdig/0.27.1/build/dynamic_params_table.o 6 CC [M] /var/lib/dkms/sysdig/0.27.1/build/fillers_table.o 7 CC [M] /var/lib/dkms/sysdig/0.27.1/build/flags_table.o 8 CC [M] /var/lib/dkms/sysdig/0.27.1/build/ppm_events.o 9 /var/lib/dkms/sysdig/0.27.1/build/main.c: In function ‘drop_event’: 10 /var/lib/dkms/sysdig/0.27.1/build/main.c:1535:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 11 1535 | nanoseconds rem; 12 | ^~~~~~~~~~~ 13 /var/lib/dkms/sysdig/0.27.1/build/main.c: In function ‘syscall_enter_probe’: 14 /var/lib/dkms/sysdig/0.27.1/build/main.c:1946:28: error: ‘SYSCALL_TABLE_ID0’ undeclared (first use in this function); did you mean ‘SYSCALL_TABLE_SIZE’? 15 1946 | table_index = id - SYSCALL_TABLE_ID0; 16 | ^~~~~~~~~~~~~~~~~ 17 | SYSCALL_TABLE_SIZE 18 /var/lib/dkms/sysdig/0.27.1/build/main.c:1946:28: note: each undeclared identifier is reported only once for each function it appears in 19 /var/lib/dkms/sysdig/0.27.1/build/main.c: In function ‘syscall_exit_probe’: 20 /var/lib/dkms/sysdig/0.27.1/build/main.c:2023:28: error: ‘SYSCALL_TABLE_ID0’ undeclared (first use in this function); did you mean ‘SYSCALL_TABLE_SIZE’? 21 2023 | table_index = id - SYSCALL_TABLE_ID0; 22 | ^~~~~~~~~~~~~~~~~ 23 | SYSCALL_TABLE_SIZE 24 make[1]: *** [scripts/Makefile.build:297: /var/lib/dkms/sysdig/0.27.1/build/main.o] Error 1 25 make[1]: *** Waiting for unfinished jobs.... 26 make: *** [Makefile:1915: /var/lib/dkms/sysdig/0.27.1/build] Error 2 [ Fix ] Enable arm64 backporting the following patch from upstream: - https://github.com/falcosecurity/libs/commit/c4f096099bf81966803d26c40c6c2cb2b8d08033 [ Test Plan ] Install and load sysdig driver on both Jammy generic and Jammy hwe on arm64: $ sudo apt install sysdig-dkms $ dkms status $ sudo modprobe sysdig-probe $ lsmod | grep sysdig + Run a typical sysdig command to test basic usage: + + $ sudo timeout 1s sysdig | tail + [ Regression potential ] We may experience regressions in systems that are using sysdig in Jammy. In particular the sysdig kernel module may fail to load, or eBPF may not be able to hook functions in kernel space to trace them properly. [ Other Info ] Up to version 0.27.1 (packaged in Jammy) the sysdig package included both a user-space component and a kernel-space component. The upstream commit 9cedb69555cc96 (build: switch to falcosecurity-libs external project) decoupled the user-space component and the kernel-space component in two different packages: - user-space -> sysdig - kernel-space -> falcosecurity-libs (https://launchpad.net/ubuntu/+source/falcosecurity-libs) Therefore the versions of sysdig greater than 0.28.0 do not suffer from this FTBFS bug. On the other hand, since this decoupling happened after Jammy was released and before Noble was released, only Noble and later series ship falcosecurity-libs. On Noble and later series both sysdig (user-space) and falcosecurity-libs (kernel-space) compile on all targeted architectures. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2114822 Title: sysdig-dkms FTBFS in Jammy on arm64 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/falcosecurity-libs/+bug/2114822/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
