Whoops, I forgot something important in my first review: this is a native package (check debian/source/format). In this case, your patch should edit the source directly, not via debian/patches.
Second, I missed that you forgot to mention the bug number in the changelog. E.g., I would expect to see: +openstack-pkg-tools (135ubuntu1) questing; urgency=medium + + * d/p/lp2116193-pbr-version.patch: don't override existing pbr + version. (LP: #2116193) + + -- Guillaume Boutry <[email protected]> Tue, 08 Jul 2025 17:39:35 +0200 + Normally if I missed that in review, I would just add it myself. But since we need another debdiff to re-work the patch anyways, please fix this as well. Sorry for missing these on the first pass! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2116193 Title: openstack-pkg-tools fails to build packages containing a git tag version To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/openstack-pkg-tools/+bug/2116193/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
