I have a few questions and comments before this is ready to be accepted. 1. Regarding the "Where problems could occur" section:
> The targeted fixes could have an impact outside of PyOtherSideQtRCImporter and cause regressions. Can you please be more specific? Where else is this code used, and how are you going to mitigate regression potential? Generally, when reviewing this section, we are looking to see that (a) the uploader understands where specifically problems might come up, and (b) the test plan has reasonable coverage to test that such regression have not been introduced. 2. On a paperwork related note: it seems that the *real* bug being fixed here is bug 2061529. Your "Impact" section basically says as much. Why is there this separate bug report for pyotherside, rather than marking the original bug as affecting both packages? Since the other bug describes the real user impact, I find the split here a bit confusing. 3. It appears to me that one of the patches contains unnecessary changes to README.md and .github/workflows/build.yaml. But, you noted in the patch description that docs/index.rst was specifically excluded since it's not relevant to an Ubuntu SRU. Are the README.md and .github/workflows/build.yaml somehow relevant in a non-obvious way? -- I am going to reject based on point 3. I cannot see any reason these changes are necessary. If they somehow are, I think that needs to be explicitly explain both in the SRU documentation, and in the patch description. Please also consider using the original bug report instead of this one, or somehow make the relationship between them a bit clearer. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2115654 Title: PyOtherSideQtRCImporter broken on Python3.12 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pyotherside/+bug/2115654/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
